-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check_microarch: require x86_64-v3 for RHEL10 #1196
Conversation
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp, e.g. from PR#42, use It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported,
See other labels for particular jobs defined in the Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra. |
249af27
to
de6f1d1
Compare
repos/system_upgrade/common/actors/checkmicroarchitecture/libraries/checkmicroarchitecture.py
Show resolved
Hide resolved
rhel9_microarch_article = reporting.ExternalLink( | ||
title='Building Red Hat Enterprise Linux 9 for the x86-64-v2 microarchitecture level', | ||
url='https://red.ht/rhel-9-intel-microarchitectures' | ||
) | ||
|
||
rhel_major_to_microarch_reqs = { | ||
'9': MicroarchInfo(microarch_ver='x86-64-v2', | ||
required_flags=(X86_64_BASELINE_FLAGS + X86_64_V2_FLAGS), | ||
extra_report_fields=[rhel9_microarch_article]), | ||
'10': MicroarchInfo(microarch_ver='x86-64-v3', | ||
required_flags=(X86_64_BASELINE_FLAGS + X86_64_V2_FLAGS + X86_64_V3_FLAGS), | ||
extra_report_fields=[]), | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a note to the OAMG-11275 ticket to not forget to implement the shortened URL when a documentation is created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. keeping unmerged for now to test it manually yet.
works as expected. tested 7 -> 8 -> 9 with IvyBridge-IBRS:
|
This patch extends the microarchitecture checks to require
x86_64-v3
CPU features when upgrading to RHEL10. The list of flags has been compiled based on thex86_64-v3
ABI description found here. The ABI CPU features were then translated to the corresponding names used by Linux kernel as found in cpufeatures.h.I have verified that the list of should be correct by making sure that the upgrade will not be inhibited on my relatively new CPU (i.e. my CPU has all the required flags).