-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .packit.yaml config #1252
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused `RHSM_REPOS` and `LEAPPDATA_BRANCH` - Update ENV variables for RHUI tests - enable upgrade path to 8.10 on AWS
Remove enabling repos step from .packit.yaml, it was moved to TF, where it logically belongs to.
mm0ran
force-pushed
the
update_packit_config
branch
from
June 7, 2024 07:16
a438f31
to
9de4488
Compare
mkluson
requested changes
Jun 7, 2024
.packit.yaml
Outdated
@@ -135,19 +123,6 @@ jobs: | |||
identifier: sanity-abstract-7to8-aws | |||
# NOTE(ivasilev) Unfortunately to use yaml templates we need to rewrite the whole tf_extra_params dict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment seems connected to the deleted lines
- Remove comment connected to deleted lines - Add BusinessUnit to all environments
mkluson
approved these changes
Jun 7, 2024
fernflower
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
This was referenced Jun 10, 2024
pirat89
added
the
changelog-checked
The merger/reviewer checked the changelog draft document and updated it when relevant
label
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-checked
The merger/reviewer checked the changelog draft document and updated it when relevant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distro_target
contextBundles the code from these PRs, and adds additional changes:
post_install_script
for RHEL 7.9 #1237