-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix storage scanner parsing error #1258
base: main
Are you sure you want to change the base?
Fix storage scanner parsing error #1258
Conversation
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
Note that first time contributors cannot run tests automatically - they need to be started by a reviewer. It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported,
See other labels for particular jobs defined in the Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra. |
@tomasfratrik rebase against master. tests should be fixed now |
37dd3a9
to
d8b36ad
Compare
/packit retest-failed |
2 similar comments
/packit retest-failed |
/packit retest-failed |
d8b36ad
to
d2cfdd0
Compare
repos/system_upgrade/common/actors/storagescanner/libraries/storagescanner.py
Outdated
Show resolved
Hide resolved
@tomasfratrik Works as expected now, please squash the commits and I can approve this. |
Output separators were before set to ':', but the output values (e.g. from command 'pvs -a') could also contain this symbol, therefore changing separator symbol fixes this issue. Jira: RHEL-34570
dfc7600
to
69bbd72
Compare
The latest push squashes commits. |
The given error arises when storage scanner actor attempts to parse output from command
pvs
while output containts separator symbol within itself. Changed the format of physical volume as was suggested in the ticket so it contains separator:
, and was given following error while preupgrade and upgrade.(e.g: format of physical volume, contains the symbol
:
`/dev/disk/by-path/pci-0000:00:03.0-part2)Therefore changing the separation symbol to
|
, and running preupgrade and upgrade from RHEL8 to RHEL9 didn't raise any errors.Jira: RHEL-34570