Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Initial docs structure and infrastructure #1272

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

matejmatuska
Copy link
Member

@matejmatuska matejmatuska commented Aug 1, 2024

NOTE: sphinx-autodoc is NOT included, because the way it works is by importing python modules, which are (apart from commands) not used in this repository, therefore it doesn't work.

In the future we could use sphinx-autoapi (https://sphinx-autoapi.readthedocs.io/en/latest/) which autogenerates docs by actually parsing source code. From my testing it will work with some tweaks.

TODO:

  • Add initial infrastructure
  • Migrate the docs regarding this project from leapp (framework) docs
  • Add AutoAPI to generate code docs (see above)

Copy link

github-actions bot commented Aug 1, 2024

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - master - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@matejmatuska matejmatuska added the docs Related to documentation label Aug 1, 2024
@matejmatuska matejmatuska force-pushed the introduce-docs branch 2 times, most recently from fae4837 to 96ef2e8 Compare September 11, 2024 06:38
help:
@source venv/bin/activate && \
$(SPHINXBUILD) -M help "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O)
livehtml:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
livehtml:
livehtml: html

this will automatically build html without the need to think about it

matejmatuska and others added 7 commits December 13, 2024 15:55
NOTE: sphinx-autodoc is NOT included, because the way it works is by
importing python modules, which are (apart from commands) not used in
this repository, therefore it doesn't work.
Add documentation entry describing some common guidelines and best
practices. Undoubtedly, some tips might be missing, but we have to
start somewhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants