-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for ARM Upgrades from RHEL8 to RHEL9.5 onwards (GRUB and kernel incompatibility) #1275
Conversation
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
Note that first time contributors cannot run tests automatically - they need to be started by a reviewer. It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported,
See other labels for particular jobs defined in the Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra. |
c434dbe
to
2e00536
Compare
/packit copr-build |
Based on your Packit configuration the settings of the @oamg/leapp Copr project would need to be updated as follows:
Packit was unable to update the settings above as it is missing To fix this you can do one of the following:
Please retrigger the build, once the issue above is fixed. |
0fbc27c
to
ca62d5b
Compare
bf761fe
to
6c9929e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, other than that it's OK.
repos/system_upgrade/el8toel9/actors/removeupgradeefientry/tests/test_removeupgradeefientry.py
Outdated
Show resolved
Hide resolved
..._upgrade/el8toel9/actors/addarmbootloaderworkaround/tests/test_addarmbootloaderworkaround.py
Show resolved
Hide resolved
..._upgrade/el8toel9/actors/addarmbootloaderworkaround/tests/test_addarmbootloaderworkaround.py
Show resolved
Hide resolved
6c9929e
to
680e8fa
Compare
Address issue with ARM system upgrades from RHEL 8 to RHEL 9.5+ caused by GRUB bootloader incompatibility with newer kernels. When attempting to load the RHEL 9.5+ kernel using the RHEL 8 bootloader, the upgrade process halts due to a boot crash. JIRA: 41193
680e8fa
to
6474514
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise LGTM
This actor addresses an issue encountered during the upgrade process on ARM systems. Specifically, the problem arises due to an incompatibility between the GRUB bootloader used in RHEL 8 and the newer kernels from RHEL 9.5 onwards. When the kernel of the target system is loaded using the bootloader from the source system, this incompatibility causes the bootloader to crash, halting the upgrade.
To mitigate this issue, the following steps are implemented:
Before the Upgrade (handled by
AddArmBootloaderWorkaround
):Create a new Upgrade EFI entry:
Preserve the original EFI boot entry and GRUB configuration:
After the Upgrade (handled by
RemoveUpgradeEFIEntry
):TODO:
JIRA: 41193