Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pylint: exclude rule: too-many-positional-arguments (code: R0917) #1299

Merged
merged 1 commit into from
Sep 27, 2024
Merged

pylint: exclude rule: too-many-positional-arguments (code: R0917) #1299

merged 1 commit into from
Sep 27, 2024

Conversation

pirat89
Copy link
Member

@pirat89 pirat89 commented Sep 27, 2024

New version of Pylint have the rule for checking of positional arguments - complaining when more than 4 positional arguments exists. We do not want to refactor the code to make it happy and the default value cannot be set right now - that's planned for future Pylint versions at this moment. So excluding this rule.

For more info:

@pirat89
pylint: exclude rule: too-many-positional-arguments (code: R0917)
1937268 
New version of Pylint have the rule for checking of positional
arguments - complaining when more than 4 positional arguments exists.
We do not want to refactor the code to make it happy and the default
value cannot be set right now - that's planned for future Pylint
versions at this moment. So excluding this rule.

For more info:
  * https://pylint.readthedocs.io/en/latest/user_guide/messages/refactor/too-many-positional-arguments.html
@pirat89 pirat89 requested a review from a team September 27, 2024 12:59
@github-actions GitHub Actions
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@pirat89
Copy link
Member Author

pirat89 commented Sep 27, 2024

@evgeni thanks! merging

@pirat89 pirat89 merged commit 88e13fb into oamg:main Sep 27, 2024
19 of 27 checks passed
@pirat89 pirat89 deleted the linter-rules branch September 27, 2024 13:06
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Sep 27, 2024
MichalHe pushed a commit to abadger/leapp that referenced this pull request Oct 29, 2024
pylint: ignore too many params/lines, yield from
2e7ebc7 
Ignore pylint's options:
* too-many-lines
* too-many-positional-arguments
* use-yield-from

Some of these options cannot be used (python2.7 compat) or configured.
See: oamg/leapp-repository#1299
MichalHe pushed a commit to abadger/leapp that referenced this pull request Nov 12, 2024
pylint: ignore too many params/lines, yield from
1ed1dfb 
Ignore pylint's options:
* too-many-lines
* too-many-positional-arguments
* use-yield-from

Some of these options cannot be used (python2.7 compat) or configured.
See: oamg/leapp-repository#1299
MichalHe pushed a commit to abadger/leapp that referenced this pull request Nov 12, 2024
pylint: ignore too many params/lines, yield from
9cb0a74 
Ignore pylint's options:
* too-many-lines
* too-many-positional-arguments
* use-yield-from

Some of these options cannot be used (python2.7 compat) or configured.
See: oamg/leapp-repository#1299
pirat89 pushed a commit to oamg/leapp that referenced this pull request Nov 13, 2024
@pirat89
pylint: ignore too many params/lines, yield from
45c1b35 
Ignore pylint's options:
* too-many-lines
* too-many-positional-arguments
* use-yield-from

Some of these options cannot be used (python2.7 compat) or configured.
See: oamg/leapp-repository#1299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pirat89 @evgeni