-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(net-naming-scheme): enable by default #1312
Conversation
This commit enables the use of net.naming-scheme for 8>9 upgrades by default. The previously used environmental variablel LEAPP_USE_NET_NAMING_SCHEMES is replaced with LEAPP_DISABLE_NET_NAMING_SCHEMES with inverse semantics.
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
Note that first time contributors cannot run tests automatically - they need to be started by a reviewer. It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported,
See other labels for particular jobs defined in the Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. untested
Tested:
On RHEL 7, 8 with LEAPP_DISABLE_NET_NAMING_SCHEMES=1 and 9 it's not logger and correctly disabled. LGTM. |
/packit retest-failed |
/packit test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ondemand tests were not intended to be ran. Some of the other are failing because of known infra issue. Merging
This commit enables the use of net.naming-scheme for 8>9 upgrades by default. The previously used environmental variable
LEAPP_USE_NET_NAMING_SCHEMES
is replaced withLEAPP_DISABLE_NET_NAMING_SCHEMES
with inverse semantics.jira: https://issues.redhat.com/browse/RHEL-23473