Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(net-naming-scheme): enable by default #1312

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

MichalHe
Copy link
Member

@MichalHe MichalHe commented Nov 19, 2024

This commit enables the use of net.naming-scheme for 8>9 upgrades by default. The previously used environmental variable LEAPP_USE_NET_NAMING_SCHEMES is replaced with LEAPP_DISABLE_NET_NAMING_SCHEMES with inverse semantics.

jira: https://issues.redhat.com/browse/RHEL-23473

This commit enables the use of net.naming-scheme for 8>9 upgrades by
default. The previously used environmental variablel
LEAPP_USE_NET_NAMING_SCHEMES is replaced with
LEAPP_DISABLE_NET_NAMING_SCHEMES with inverse semantics.
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

Copy link
Member

@pirat89 pirat89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. untested

@matejmatuska
Copy link
Member

Tested:
On RHEL 8 with LEAPP_DISABLE_NET_NAMING_SCHEMES=0, the actor does run:

Skipping generation of .link files renaming NICs as net.naming-scheme {LEAPP_DISABLE_NET_NAMING_SCHEMES != 1} is enabled and upgrade is 8>9

On RHEL 7, 8 with LEAPP_DISABLE_NET_NAMING_SCHEMES=1 and 9 it's not logger and correctly disabled.

LGTM.

@matejmatuska
Copy link
Member

/packit retest-failed

@matejmatuska
Copy link
Member

/packit test

Copy link
Member

@matejmatuska matejmatuska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ondemand tests were not intended to be ran. Some of the other are failing because of known infra issue. Merging

@matejmatuska matejmatuska merged commit 3c3421a into oamg:main Nov 19, 2024
21 of 32 checks passed
@pirat89 pirat89 added the enhancement New feature or request label Nov 19, 2024
@pirat89 pirat89 added this to the 8.10/9.6 milestone Nov 19, 2024
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants