Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inhibit upgrades with unsupported XFS #1318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dkubek
Copy link
Member

@dkubek dkubek commented Dec 9, 2024

RHEL 10 introduces stricter requirements for XFS filesystems. If any XFS filesystem on the system lack these required features, the upgrade will be inhibited.

JIRA:
RHELMISC-8212 (spike)
RHEL-60034

Copy link

github-actions bot commented Dec 9, 2024

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@dkubek dkubek marked this pull request as draft December 9, 2024 12:00
RHEL 10 introduces stricter requirements for XFS filesystems. If any XFS
filesystem on the system lack these required features, the upgrade will
be inhibited.

JIRA: RHEL-60034
@dkubek
Copy link
Member Author

dkubek commented Dec 16, 2024

Note for reviewers. To test the code using different XFS configurations you can create the filesystem in a file:

# 1. Create a sparse file
fallocate -l 500M test_xfs.img

# 2. Format the file with an XFS filesystem (for example, with crc 0)
mkfs.xfs -f test_xfs.img  -m crc=0

# 3. Create a mount point
mkdir -p /mnt/test_xfs

# 4. Attach the file to a loop device
LOOP_DEVICE=$(losetup -f --show test_xfs.img)

# 5. Mount the loop device
mount $LOOP_DEVICE /mnt/test_xfs

@dkubek dkubek marked this pull request as ready for review December 16, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant