Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention end to end tests in docs #84

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Mention end to end tests in docs #84

merged 1 commit into from
Feb 25, 2019

Conversation

bocekm
Copy link
Member

@bocekm bocekm commented Feb 21, 2019 •
edited
Loading

.. to complete the picture of what testing we have for Leapp.

@bocekm bocekm added the documentation Docs/comments with no functional change label Feb 21, 2019
@bocekm bocekm requested review from AloisMahdal and tcerna February 21, 2019 14:12
@AloisMahdal
Copy link

The content of the mention is correct, although I'm not sure about the reason why mention it in the first place? Assuming the audience is general upstream community, wouldn't adding another category that is not very useful to them make things confusing?

@bocekm
Copy link
Member Author

bocekm commented Feb 21, 2019

The audience is also internal Red Hat community (and I assume it will be the majority) as we point to this document from many other places. Without this change, the information about the tests would be simply incomplete.

@AloisMahdal
Copy link

I'm not sure why this should be reviewed by OAMG-QE. Sure, the title seems that the change is relevant to us, but then the actual commit overreaches it by rewriting the whole page. So 90% of the commit is about unit/component tests which are completely outside our range.

@bocekm bocekm requested a review from a team February 22, 2019 09:14
@bocekm
Copy link
Member Author

bocekm commented Feb 22, 2019

Ok, I've added the other reviewers as well.

artmello
artmello previously approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@artmello artmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small comment that, for me, can be handled in another PR.

docs/tests.md Show resolved Hide resolved
vojtechsokol
vojtechsokol reviewed Feb 23, 2019
View reviewed changes
docs/tests.md Outdated Show resolved Hide resolved
docs/tests.md Outdated Show resolved Hide resolved
pirat89
pirat89 approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@pirat89 pirat89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bocekm bocekm merged commit 009773d into master Feb 25, 2019
@pirat89 pirat89 deleted the e2e_tests_to_doc branch May 18, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtechsokol vojtechsokol vojtechsokol approved these changes

@pirat89 pirat89 pirat89 approved these changes

@artmello artmello artmello left review comments

@AloisMahdal AloisMahdal Awaiting requested review from AloisMahdal

@tcerna tcerna Awaiting requested review from tcerna

Assignees
No one assigned
Labels
documentation Docs/comments with no functional change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bocekm @AloisMahdal @pirat89 @artmello @vojtechsokol