Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Add some initramfs debugging basics #796
base: main
Are you sure you want to change the base?
[Draft] Add some initramfs debugging basics #796
Changes from all commits
df2799e
3cb7a6a
35ea51c
54f638a
c9b7be8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before
chroot
, kernel interfaces such as /dev /sys /proc should be mounted into the/sysroot
. Otherwise some commands, e.glsblk
won't work.I am not sure if you assume this knowledge or if it should be in the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should definitely be in the docs, assumed knowledge is always knowledge lost :)
Do you have a ready to run command to share?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can look at the
leapp_dbg_chroot
funtion in #997, but I am not 100% sure all of them are included here.Maybe we can wait until #997 is merged and then just point to the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chroot is problematic from this POV (depends, what everything you would like to do inside and what are expectations). from the point of upgrades, we should always run it in the same way as leapp, creating the systemd-nspawn container with the all parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fernflower This is not good place to add this information. Keep in mind you are adding information about a initramfs debugging that is completely irrelevant for the framework. This is the framework documentation, not documentation for the content provided by leapp-repositories. If any debugging instrusctionts regarding that should be provided, it should not be here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is related to leapp as a whole, not repositories only, and as leapp has been historically containing general debugging docs (like how to debug actors with rpdb information you see above) I decided to put initramfs debugging there as well.
I want this information to be public but I am not opposed to moving it, just tell where should I move it to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can find el7toel8 directory inside docs. You need to come up where under docs specific for our upgrade repositories we should put it. We have already a task to separate leapp & leapp-repository docs, however there was no time to deal with it yet.