Increase resource limits to prevent crashes #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Leapp was run with low resource limits, a crash would occur. This commit adjusts the resource limits to higher values to prevent such crashes: * The first limit increased is the maximum number of open file descriptors. * The second is the limit for the maximum writable file size. Resolves: RHEL-26459 and RHEL-16881
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
To launch regression testing public members of oamg organization can leave the following comment:
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
|
/packit copr-build |
|
/packit retest-failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Leapp was run with low resource limits, a crash would occur. This commit adjusts the resource limits to higher values to prevent such crashes:
Note that this fix was first implemented into leapp-repository, but with fsize values being too low, the leapp tool started to crash, thats why it has to be implemented into the framework.
Successfully tested with very low fzise values (ulimit -f 1 && leapp preugrade passes).
Resolves: RHEL-26459 and RHEL-16881