Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of progress reporting #100

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

andywaltlova
Copy link
Collaborator

@andywaltlova andywaltlova commented Oct 24, 2023

HMS-3622

  • worker is able to capture script stdout/phase log info to have something to report
  • format the report to required message for dispatcher/ingress
  • tests

@andywaltlova
Copy link
Collaborator Author

After properly testing it locally I will need to figur out with other teams how should we report the progress - because playbook worker does it in some mysterious way through ansible and several events - AFAIK only remediations app uses it.

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Attention: Patch coverage is 73.21429% with 15 lines in your changes missing coverage. Please review.

Project coverage is 66.89%. Comparing base (7d25e46) to head (864af76).
Report is 44 commits behind head on main.

Files Patch % Lines
src/runner.go 73.21% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   64.20%   66.89%   +2.69%     
==========================================
  Files           5        5              
  Lines         338      293      -45     
==========================================
- Hits          217      196      -21     
+ Misses        101       75      -26     
- Partials       20       22       +2     
Flag Coverage Δ
go-1.19 66.89% <73.21%> (+2.69%) ⬆️
go-1.20 66.89% <73.21%> (+2.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andywaltlova andywaltlova force-pushed the feat/add-progress-reporting branch 7 times, most recently from 3b8a9f5 to c331766 Compare October 27, 2023 09:57
Signed-off-by: Andrea Waltlova <[email protected]>
…n for that buffer for stdout

flush python script stdout after every print to force 'progress' reporting

Signed-off-by: Andrea Waltlova <[email protected]>
Signed-off-by: Andrea Waltlova <[email protected]>
@andywaltlova andywaltlova force-pushed the feat/add-progress-reporting branch from b28987e to 864af76 Compare February 8, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants