This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
enable C++17 support #1142
Draft
enable C++17 support #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Zhou <[email protected]>
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/native-sql-engine/issues Then could you also rename commit message and pull request title in the following format? See also: |
Signed-off-by: Yuan Zhou <[email protected]>
zhouyuan
force-pushed
the
wip_c++17
branch
2 times, most recently
from
9c876c8
to
f5b9a8f
Compare
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
jackylee-ch
reviewed
Oct 24, 2022
| // C++17 based from_chars | ||
| // std::from_chars(str.data(), str.data() + str.size(), result); | ||
| func_str = " = std::from_chars"; | ||
| prepare_ss << "int result = 0" << std::endl; |
There was a problem hiding this comment.
miss a semicolon after 0 and an #include <charconv> in wscgapi.hpp.
| // C++17 based from_chars | ||
| // std::from_chars(str.data(), str.data() + str.size(), result); | ||
| func_str = " = std::from_chars"; | ||
| prepare_ss << "long int result = 0" << std::endl; |
There was a problem hiding this comment.
miss a semicolon after 0
| } else if (func_name.compare("castFLOAT4OrNull") == 0) { | ||
| func_str = " = std::stof"; | ||
| func_str = " = ::arrow_vendored::fast_float::from_chars"; | ||
| prepare_ss << "float result = 0" << std::endl; |
| } else { | ||
| func_str = " = std::stod"; | ||
| func_str = " = ::arrow_vendored::fast_float::from_chars"; | ||
| prepare_ss << "double result = 0" << std::endl; |
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
jackylee-ch
reviewed
Oct 25, 2022
| @@ -3,8 +3,10 @@ | |||
| #include <arrow/buffer.h> | |||
| #include <arrow/compute/api.h> | |||
| #include <arrow/record_batch.h> | |||
| #include <arrow/util/value_parsing.h> | |||
There was a problem hiding this comment.
#include <arrow/vendored/fast_float/parse_number.h> should be added here.
And also this arrow pr should be added before this pr merged. https://github.com/oap-project/arrow/pull/173/files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuan Zhou [email protected]
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)