Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e-regression: Use block range in Eden #596

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

mitjat
Copy link
Contributor

@mitjat mitjat commented Dec 23, 2023

This PR moves the target range of the e2e regression test: We now query a subrange in Eden.

I have manually changed many of the target URLs in run.sh so that they pull data that is actually indexed in this limited set of blocks.

Benefits of moving to Eden:

  • We are more likely to notice any mishandling of the data as presented by the current (= most relevant) version of the node
  • Internal deployment of Damask node is currently semi-broken, preventing any changes to the e2e-regression outputs. Moving away from Damask lets us make more changes to nexus without disabling the e2e-regression tests.

Downsides of moving to Eden:

  • Emerald blocks (at least the ones I tried) have less activity overall, so outputs are sparser and less likely to catch bugs.

Copy link
Collaborator

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting that some changes between chunked and content-length-known response headers

@mitjat mitjat force-pushed the mitjat/e2e-regression-eden branch from dd44d94 to d484d54 Compare December 23, 2023 10:08
@mitjat mitjat force-pushed the mitjat/e2e-regression-eden branch from d484d54 to b1f7521 Compare January 8, 2024 12:29
@mitjat mitjat merged commit 84ca324 into main Jan 8, 2024
6 checks passed
@mitjat mitjat deleted the mitjat/e2e-regression-eden branch January 8, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants