Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: enum proposal states #612

Merged
merged 1 commit into from
Jan 23, 2024
Merged

api: enum proposal states #612

merged 1 commit into from
Jan 23, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jan 23, 2024

Based on

StateActiveName = "active"
StatePassedName = "passed"
StateRejectedName = "rejected"
StateFailedName = "failed"

Copy link
Contributor

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I extracted the enum into an explicitly named type and also used it on the query side (where you can specify which proposals you want to retrieve).

@lukaw3d lukaw3d enabled auto-merge January 23, 2024 22:24
@lukaw3d lukaw3d merged commit 3938ba3 into main Jan 23, 2024
6 checks passed
@lukaw3d lukaw3d deleted the lw/enum-proposal branch January 23, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants