-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go: Remove TLS certificate rotation #5318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberci
force-pushed
the
jberci/feature/rotation
branch
from
July 11, 2023 10:36
79807f4
to
a26ea27
Compare
kostko
reviewed
Jul 23, 2023
jberci
force-pushed
the
jberci/feature/rotation
branch
from
July 31, 2023 16:13
a26ea27
to
47f1829
Compare
kostko
reviewed
Aug 1, 2023
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
August 1, 2023 16:03
peternose
reviewed
Aug 1, 2023
jberci
force-pushed
the
jberci/feature/rotation
branch
2 times, most recently
from
August 11, 2023 01:29
2460e98
to
219ff43
Compare
peternose
reviewed
Aug 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #5318 +/- ##
==========================================
+ Coverage 66.82% 66.90% +0.08%
==========================================
Files 525 525
Lines 55907 55763 -144
==========================================
- Hits 37360 37311 -49
+ Misses 13983 13909 -74
+ Partials 4564 4543 -21
|
jberci
force-pushed
the
jberci/feature/rotation
branch
from
August 15, 2023 13:35
219ff43
to
a01ebe5
Compare
peternose
reviewed
Aug 15, 2023
jberci
force-pushed
the
jberci/feature/rotation
branch
from
August 15, 2023 14:07
a01ebe5
to
50f342a
Compare
kostko
approved these changes
Aug 16, 2023
peternose
approved these changes
Aug 16, 2023
jberci
force-pushed
the
jberci/feature/rotation
branch
from
August 16, 2023 23:11
50f342a
to
a683d30
Compare
kostko
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.