Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Bump ed25519-dalek, sha2, hmac, rsa #5351

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

kostko
Copy link
Member

@kostko kostko commented Aug 17, 2023

  • runtime: Bump ed25519-dalek to 2.0.0
  • runtime: Bump sha2 to 0.10.7, hmac to 0.12.1
  • runtime: Bump rsa to 0.9.2

@kostko kostko added the c:deps Category: external dependencies label Aug 17, 2023
@kostko kostko force-pushed the kostko/feature/bump-ed25519-dalek-2.0.0 branch from 5512e75 to da95a7e Compare August 17, 2023 08:36
@kostko kostko force-pushed the kostko/feature/bump-ed25519-dalek-2.0.0 branch from da95a7e to 4e91c1a Compare August 17, 2023 09:32
@kostko kostko marked this pull request as ready for review August 17, 2023 09:33
@kostko kostko force-pushed the kostko/feature/bump-ed25519-dalek-2.0.0 branch from 4e91c1a to 9da4f41 Compare August 17, 2023 09:43
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #5351 (5fca705) into master (b62f53c) will increase coverage by 0.10%.
Report is 4 commits behind head on master.
The diff coverage is 93.65%.

@@            Coverage Diff             @@
##           master    #5351      +/-   ##
==========================================
+ Coverage   66.82%   66.93%   +0.10%     
==========================================
  Files         525      525              
  Lines       55907    55763     -144     
==========================================
- Hits        37360    37323      -37     
+ Misses      13983    13909      -74     
+ Partials     4564     4531      -33     
Files Changed Coverage Δ
go/worker/common/committee/accessctl.go 0.00% <ø> (ø)
go/oasis-node/cmd/identity/identity.go 52.17% <50.00%> (ø)
go/common/node/node.go 75.00% <66.66%> (+1.47%) ⬆️
go/common/identity/identity.go 78.31% <90.90%> (+5.17%) ⬆️
go/common/grpc/grpc.go 77.29% <100.00%> (+1.43%) ⬆️
go/consensus/cometbft/tests/genesis/genesis.go 91.48% <100.00%> (-0.24%) ⬇️
go/ias/proxy/client/client.go 62.16% <100.00%> (ø)
go/oasis-node/cmd/common/grpc/grpc.go 82.69% <100.00%> (-0.33%) ⬇️
go/oasis-node/cmd/node/init.go 40.24% <100.00%> (ø)
go/oasis-node/cmd/node/node_control.go 53.81% <100.00%> (ø)
... and 5 more

... and 43 files with indirect coverage changes

runtime/src/common/bytes.rs Show resolved Hide resolved
runtime/src/common/crypto/x25519.rs Outdated Show resolved Hide resolved
Even though this changes the byte-for-byte representation of returned
keys, this should have no effect on clients using them for X25519 which
will clamp internally. The only other use case is the VRF key derivation
for the RNG in the runtime SDK, but that does only uses ephemeral keys
from the latest epoch.
@kostko kostko force-pushed the kostko/feature/bump-ed25519-dalek-2.0.0 branch from 371194d to 5fca705 Compare August 17, 2023 19:03
@kostko kostko enabled auto-merge August 17, 2023 19:11
@kostko kostko disabled auto-merge August 18, 2023 05:30
@kostko kostko merged commit c06eb07 into master Aug 18, 2023
3 checks passed
@kostko kostko deleted the kostko/feature/bump-ed25519-dalek-2.0.0 branch August 18, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:deps Category: external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants