-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: Bump ed25519-dalek, sha2, hmac, rsa #5351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kostko
commented
Aug 17, 2023
- runtime: Bump ed25519-dalek to 2.0.0
- runtime: Bump sha2 to 0.10.7, hmac to 0.12.1
- runtime: Bump rsa to 0.9.2
kostko
force-pushed
the
kostko/feature/bump-ed25519-dalek-2.0.0
branch
from
August 17, 2023 08:36
5512e75
to
da95a7e
Compare
kostko
force-pushed
the
kostko/feature/bump-ed25519-dalek-2.0.0
branch
from
August 17, 2023 09:32
da95a7e
to
4e91c1a
Compare
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
August 17, 2023 09:33
kostko
force-pushed
the
kostko/feature/bump-ed25519-dalek-2.0.0
branch
from
August 17, 2023 09:43
4e91c1a
to
9da4f41
Compare
Codecov Report
@@ Coverage Diff @@
## master #5351 +/- ##
==========================================
+ Coverage 66.82% 66.93% +0.10%
==========================================
Files 525 525
Lines 55907 55763 -144
==========================================
- Hits 37360 37323 -37
+ Misses 13983 13909 -74
+ Partials 4564 4531 -33
|
peternose
reviewed
Aug 17, 2023
Even though this changes the byte-for-byte representation of returned keys, this should have no effect on clients using them for X25519 which will clamp internally. The only other use case is the VRF key derivation for the RNG in the runtime SDK, but that does only uses ephemeral keys from the latest epoch.
kostko
force-pushed
the
kostko/feature/bump-ed25519-dalek-2.0.0
branch
from
August 17, 2023 19:03
371194d
to
5fca705
Compare
peternose
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.