fix consensus light client status shows empty peer IDs #5408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
peternose
as code owners
ptrus
force-pushed
the
ptrus/fix/empty-peer-id
branch
4 times, most recently
from
b2744c3
to
a194aee
Compare
kostko
approved these changes
Oct 19, 2023
No, I think it makes more sense to just skip these. |
ptrus
force-pushed
the
ptrus/fix/empty-peer-id
branch
from
a194aee
to
993d58e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively could also set it to something like
<uninitialized>in the status instead of skipping.TODO: backport