Add Dockerfile for developing ROFL #2063
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-sdk ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jberci
requested review from
kostko,
pro-wh,
ptrus and
peternose
as code owners
jberci
force-pushed
the
jberci/feature/macos-docker
branch
from
0cf620f
to
0554b1b
Compare
matevz
reviewed
Nov 15, 2024
| @@ -77,20 +98,18 @@ nightly-2022-08-22-x86_64-unknown-linux-gnu (overridden by '/code/rust-toolchain | |||
| rustc 1.65.0-nightly (c0941dfb5 2022-08-21) | |||
| ``` | |||
|
|
|||
| For testing ROFL binaries on Sapphire Localnet, the binaries should be compiled | |||
| for [MUSL C standard library]. You will need to add the following target to your | |||
There was a problem hiding this comment.
Feel free to remove the [MUSL C standard library] URL below .
matevz
reviewed
Nov 15, 2024
| the next section of this guide: | ||
|
|
||
| ```bash | ||
| docker run --platform linux/amd64 --volume ./rofl-oracle:/src -it ghcr.io/oasisprotocol/rofl-dev |
There was a problem hiding this comment.
This command could actually be expanded in the application.md chapter to include full build commands.
lukaw3d
reviewed
Nov 15, 2024
| @@ -0,0 +1,9 @@ | |||
| FROM ghcr.io/oasisprotocol/oasis-core-dev:stable-24.3.x AS oasis-core-dev | |||
|
|
|||
| ARG OASIS_CLI_VERSION=0.10.3 | |||
There was a problem hiding this comment.
Related to oasisprotocol/cli#319
lukaw3d
reviewed
Nov 15, 2024
| you can install those by running: | ||
|
|
||
| ```shell | ||
| sudo apt install musl-tools gcc-multilib clang | ||
| sudo apt install gcc-multilib clang |
There was a problem hiding this comment.
Note: when trying to run it in ubuntu docker (and devcontainer), it also required:
sudo apt update
sudo apt -y install pkg-config protobuf-compiler cmake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.