This repository has been archived by the owner on Nov 23, 2021. It is now read-only.
Issue/621 #624
Merged
Issue/621 #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieu-lavigne
force-pushed
the
issue/621
branch
from
405acba to
f5be404
Compare
hohwille
suggested changes
Jan 25, 2018
| */ | ||
| protected Collection<ID> toCollection(Iterable<ID> ids) { | ||
|
|
||
| final Collection<ID> idsList = new ArrayList<>(); |
There was a problem hiding this comment.
Will technically fix it but is a kind of waste if the Iterable already is a Collection. IMHO we should first check with instanceof and then only cast to avoid pointless conversion. WDYT?
There was a problem hiding this comment.
You are absolutely right. I'll change my PR.
Do not recreate Collection declared as Iterable has it is already a Collection
hohwille
approved these changes
Jan 25, 2018
|
IMHO now perfect. @mathieu-lavigne 👍 thanks a lot for your active collaboration! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR for issue #621