Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update methods to lodash 4 verios #330

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

taopkorczak
Copy link
Contributor

Related: https://oat-sa.atlassian.net/browse/ADF-1579

Update lodash methods to version 4.
Documentation: https://github.com/lodash/lodash/wiki/Migrating

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9749b6) 13.36% compared to head (55b548a) 13.36%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #330   +/-   ##
==========================================
  Coverage      13.36%   13.36%           
  Complexity       269      269           
==========================================
  Files             22       22           
  Lines            868      868           
==========================================
  Hits             116      116           
  Misses           752      752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Nicholass Nicholass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is the _.min usage. In lodash4 _.min is accepting the only one arg - the array. I believe for our case the _.minBy should be used

Copy link

github-actions bot commented Dec 20, 2023

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
131 131 0 0

@wazelin wazelin force-pushed the feature/ADF-1579/update-lodash-to-4 branch from 3fead63 to 27f179d Compare February 1, 2024 16:38
Copy link

github-actions bot commented Feb 1, 2024

Version

Target Version 8.5.4
Last version 8.5.3

There are 0 BREAKING CHANGE, 0 feature, 3 fixes

@wazelin wazelin merged commit fc4b3c7 into develop Feb 1, 2024
6 checks passed
@wazelin wazelin deleted the feature/ADF-1579/update-lodash-to-4 branch February 1, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants