Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: remove lodash #640

Merged
merged 2 commits into from
Feb 1, 2024
Merged

feature: remove lodash #640

merged 2 commits into from
Feb 1, 2024

Conversation

taopkorczak
Copy link
Contributor

Related: https://oat-sa.atlassian.net/browse/ADF-1579

Remove lodash usage

@taopkorczak taopkorczak requested a review from oatymart November 8, 2023 09:18
Copy link
Contributor

@oatymart oatymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok at first glance. I'll approve after I test. Please change target branch to develop meanwhile.

@taopkorczak taopkorczak changed the base branch from master to develop December 20, 2023 22:33
@oatymart
Copy link
Contributor

oatymart commented Jan 3, 2024

In views/package.json, a dependency needs to be upgraded:

  • @oat-sa/tao-item-runner to 1.0.0

Copy link

github-actions bot commented Jan 4, 2024

Version

Target Version 12.2.0
Last version 12.1.2

There are 0 BREAKING CHANGE, 1 feature, 1 fix

Copy link

github-actions bot commented Jan 4, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
29 27 0 2

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cdd9942) 15.95% compared to head (2cadb21) 15.95%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #640   +/-   ##
==========================================
  Coverage      15.95%   15.95%           
  Complexity       558      558           
==========================================
  Files             50       50           
  Lines           1749     1749           
==========================================
  Hits             279      279           
  Misses          1470     1470           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taopkorczak taopkorczak requested a review from oatymart February 1, 2024 11:35
@wazelin wazelin merged commit 7207c6f into develop Feb 1, 2024
3 of 6 checks passed
@wazelin wazelin deleted the feature/ADF-1579/lodash-remove branch February 1, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants