Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feture/aut 3978 export items as qti3 package #2650

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

Karol-Stelmaczonek
Copy link
Contributor

@Karol-Stelmaczonek Karol-Stelmaczonek commented Dec 18, 2024

Ticket: https://oat-sa.atlassian.net/browse/AUT-3978

What's Changed

  • Ability to export items as qti3 package

How to test

  • Go to items in Authoring, create new or use existing item.
  • Click "Export" button and choose "QTI3.0 Package" option and click Export.
  • Wait until task will end and download a package.
  • You can validate it using validator

Dependencies PRs

Video

Screenshare.-.2024-12-18.2_57_56.PM.mp4

@Karol-Stelmaczonek Karol-Stelmaczonek changed the base branch from master to develop December 18, 2024 12:57
@Karol-Stelmaczonek Karol-Stelmaczonek changed the title Feture/aut 3978 item export qti3 Feture/aut 3978 export items as qti3 package Dec 18, 2024
@Karol-Stelmaczonek Karol-Stelmaczonek marked this pull request as ready for review December 18, 2024 13:58
@Karol-Stelmaczonek Karol-Stelmaczonek requested review from a team, tikhanovichA, bartlomiejmarszal, KirylHatalski, pnal and viktar-dzmitryieu-tao and removed request for a team December 18, 2024 13:59
Copy link

github-actions bot commented Dec 18, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
287 287 0 0

model/Export/Qti3Package/Exporter.php Outdated Show resolved Hide resolved
model/Export/Qti3Package/Exporter.php Outdated Show resolved Hide resolved
model/Export/Qti3Package/TransformationService.php Outdated Show resolved Hide resolved
model/Export/Qti3Package/TransformationService.php Outdated Show resolved Hide resolved
Copy link
Contributor

@tikhanovichA tikhanovichA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic
  • Changelog is updated according to changes (if applicable)
  • Documentation is updated according to changes (if applicable)

Copy link
Contributor

@bartlomiejmarszal bartlomiejmarszal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions.

model/Export/Qti3Package/Exporter.php Outdated Show resolved Hide resolved
model/Export/Qti3Package/Exporter.php Outdated Show resolved Hide resolved
model/Export/Qti3Package/Exporter.php Outdated Show resolved Hide resolved
model/Export/Qti3Package/ExporterFactory.php Outdated Show resolved Hide resolved
model/Export/Qti3Package/ExporterFactory.php Show resolved Hide resolved
model/Export/Qti3Package/Qti3XsdValidator.php Outdated Show resolved Hide resolved
model/Export/Qti3Package/Qti3XsdValidator.php Outdated Show resolved Hide resolved
model/Export/Qti3Package/Qti3XsdValidator.php Outdated Show resolved Hide resolved
@bartlomiejmarszal bartlomiejmarszal self-requested a review January 9, 2025 09:15
Copy link

github-actions bot commented Jan 9, 2025

Version

Target Version 30.26.0
Last version 30.25.4

There are 0 BREAKING CHANGE, 4 features, 10 fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants