Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Bootstrap css and js from child theme #52

Open
wants to merge 3 commits into
base: 2.1.0
Choose a base branch
from
Open

Get Bootstrap css and js from child theme #52

wants to merge 3 commits into from

Commits on Apr 6, 2013

  1. Allow bootstrap css and js from child theme 

    Adds an option to the theme customizer (inc/theme-customizer.php) and
corresponding changes to functions.php that allows a person using a
child theme to choose to pull Bootstrap (css and js) from the child
theme's css and js directories.

This change allows people using the-bootstrap to compile a custom
version of Bootstrap css files with LESS without overwriting the parent
theme's css files and avoid overriding default colors, fonts, etc. in
their child theme's styles. This can significant simplify child theme
customization and reduce the total size of CSS to load. Tools like
bootswatchr.com make custom Bootstrap easy even for people who aren't
comfortable with LESS tools.

This change also allows theme users to update Bootstrap out of sync with
the parent theme without overwriting the parent's copies of Bootstrap
files. This makes it easier to identify if problems are caused by
Bootstrap customization (now isolated to the child) or are in
the-bootstrap without custom Bootstrap files.
    @jmjf
    jmjf committed Apr 6, 2013
    Configuration menu
    Copy the full SHA
    2fc82be View commit details
    Browse the repository at this point in the history

  2. formatting 

    forgot a space when making Yoda condition (per WP coding standards)
    @jmjf
    jmjf committed Apr 6, 2013
    Configuration menu
    Copy the full SHA
    0009bad View commit details
    Browse the repository at this point in the history

  3. fix style name 

    Forgot to change stylesheet id for child theme bootstrap. Caused
bootstrap.min.css to fail loading when child-bootstrap selected.
Changing to 'child-bootstrap' worked in test.
    @jmjf
    jmjf committed Apr 6, 2013
    Configuration menu
    Copy the full SHA
    bbf3b19 View commit details
    Browse the repository at this point in the history