Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initializes Slint gui #1084

Merged
merged 64 commits into from
Nov 11, 2024
Merged

Initializes Slint gui #1084

merged 64 commits into from
Nov 11, 2024

Conversation

SuchAFuriousDeath
Copy link
Contributor

@SuchAFuriousDeath SuchAFuriousDeath commented Nov 3, 2024 •
edited by ultimaweapon
Loading

Closes #238.

@SuchAFuriousDeath SuchAFuriousDeath requested a review from a team November 3, 2024 15:06
@ultimaweapon
Copy link
Member

Require #1083 to merge first.

@ultimaweapon
Copy link
Member

You need to change add_crate(gui) to add_crate(gui LIBRARY).

@ultimaweapon
Copy link
Member

#238 should be able to close by this PR.

@ultimaweapon
Copy link
Member

Seems like this PR is going too big. My idea is just pushing only the GUI without functionality first.

@SuchAFuriousDeath SuchAFuriousDeath marked this pull request as ready for review November 6, 2024 14:28
ultimaweapon
ultimaweapon requested changes Nov 6, 2024
View reviewed changes
.github/workflows/ci-mac.yml Outdated Show resolved Hide resolved
.vscode/launch.json Outdated Show resolved Hide resolved
@VocalFan
Copy link
Member

VocalFan commented Nov 9, 2024

I will just keep watching from the distance... Also known as emails from github.

ultimaweapon
ultimaweapon requested changes Nov 9, 2024
View reviewed changes
gui/src/rlim.rs Outdated Show resolved Hide resolved
gui/src/rlim.rs Outdated Show resolved Hide resolved
gui/src/rlim.rs Outdated Show resolved Hide resolved
ultimaweapon
ultimaweapon requested changes Nov 9, 2024
View reviewed changes
gui/src/rlim.rs Outdated Show resolved Hide resolved
gui/src/rlim.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added S-ready Status: Ready for review and removed S-ready Status: Ready for review labels Nov 9, 2024
ultimaweapon
ultimaweapon requested changes Nov 10, 2024
View reviewed changes
gui/src/vmm/hv/mod.rs Outdated Show resolved Hide resolved
ultimaweapon
ultimaweapon requested changes Nov 10, 2024
View reviewed changes
gui/src/vmm/mod.rs Outdated Show resolved Hide resolved
ultimaweapon
ultimaweapon requested changes Nov 10, 2024
View reviewed changes
gui/src/main.rs Outdated Show resolved Hide resolved
gui/src/main.rs Outdated Show resolved Hide resolved
gui/src/main.rs Outdated Show resolved Hide resolved
gui/src/main.rs Outdated Show resolved Hide resolved
gui/src/main.rs Outdated Show resolved Hide resolved
gui/src/main.rs Outdated Show resolved Hide resolved
ultimaweapon
ultimaweapon requested changes Nov 10, 2024
View reviewed changes
gui/src/main.rs Outdated Show resolved Hide resolved
gui/src/main.rs Outdated Show resolved Hide resolved
gui/src/main.rs Outdated Show resolved Hide resolved
@ultimaweapon ultimaweapon merged commit 296cc3e into obhq:main Nov 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ultimaweapon ultimaweapon ultimaweapon approved these changes

Assignees
No one assigned
Labels
S-ready Status: Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try Slint as a new GUI
3 participants
@SuchAFuriousDeath @ultimaweapon @VocalFan