Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes raw_window_handle, uses Cstr literals #1103

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Removes raw_window_handle, uses Cstr literals #1103

merged 1 commit into from
Nov 16, 2024

Conversation

SuchAFuriousDeath
Copy link
Contributor

@SuchAFuriousDeath SuchAFuriousDeath commented Nov 16, 2024 •
edited
Loading

I didn't notice that cbdingen had a new release. I though a new version would appear on the Github repo:
image

@ultimaweapon
Copy link
Member

ultimaweapon commented Nov 16, 2024 •
edited
Loading

I though we need raw_window_handle to access Vulkan surface and Metal layer?

@SuchAFuriousDeath
Copy link
Contributor Author

SuchAFuriousDeath commented Nov 16, 2024 •
edited
Loading

I though we need raw_window_handle to access Vulkan surface and Metal layer?

Eventually, but we do not depend on it right now. I'll put it back once it is actually required.

@github-actions github-actions bot added the S-ready Status: Ready for review label Nov 16, 2024
@ultimaweapon ultimaweapon merged commit d26c0c9 into obhq:main Nov 16, 2024
6 checks passed
@SuchAFuriousDeath SuchAFuriousDeath deleted the cstr-literals branch November 16, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ultimaweapon ultimaweapon ultimaweapon approved these changes

Assignees
No one assigned
Labels
S-ready Status: Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuchAFuriousDeath @ultimaweapon