Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapper type for signals, refactor errors and signal numbers #595

Merged
merged 42 commits into from
Feb 24, 2024
Merged

Wrapper type for signals, refactor errors and signal numbers #595

merged 42 commits into from
Feb 24, 2024

Conversation

SuchAFuriousDeath
Copy link
Contributor

No description provided.

@SuchAFuriousDeath SuchAFuriousDeath requested a review from a team February 3, 2024 10:38
@SuchAFuriousDeath SuchAFuriousDeath changed the title Refactors signals Wrapper type for signal, redefine signals and errnos using macros Feb 3, 2024
@SuchAFuriousDeath SuchAFuriousDeath changed the title Wrapper type for signal, redefine signals and errnos using macros Wrapper type for signals, redefine signal numbers using macro Feb 3, 2024
@SuchAFuriousDeath SuchAFuriousDeath marked this pull request as draft February 3, 2024 11:06
@SuchAFuriousDeath SuchAFuriousDeath marked this pull request as ready for review February 3, 2024 11:18
@SuchAFuriousDeath SuchAFuriousDeath changed the title Wrapper type for signals, redefine signal numbers using macro Wrapper type for signals, refactor errors and signal numbers Feb 3, 2024
@SuchAFuriousDeath
Copy link
Contributor Author

@ultimaweapon This one is pretty safe to merge too, I would say. This is just an internal refactor, you don't have to compare anything with the PS4

ultimaweapon
ultimaweapon requested changes Feb 5, 2024
View reviewed changes
src/kernel/src/errno.rs Outdated Show resolved Hide resolved
@ultimaweapon
Copy link
Member

I saw you have changes some of the strerror. Where did you get those changes from?

@SuchAFuriousDeath
Copy link
Contributor Author

I must have missed those. I got them through copilot 💀

@SuchAFuriousDeath
Copy link
Contributor Author

@ultimaweapon They should be correct now.

ultimaweapon
ultimaweapon requested changes Feb 18, 2024
View reviewed changes
src/kernel/src/signal/mod.rs Outdated Show resolved Hide resolved
ultimaweapon
ultimaweapon requested changes Feb 24, 2024
View reviewed changes
src/kernel/src/errno.rs Outdated Show resolved Hide resolved
src/kernel/src/signal/mod.rs Outdated Show resolved Hide resolved
src/kernel/src/signal/mod.rs Outdated Show resolved Hide resolved
ultimaweapon
ultimaweapon requested changes Feb 24, 2024
View reviewed changes
src/kernel/src/signal/mod.rs Outdated Show resolved Hide resolved
ultimaweapon
ultimaweapon requested changes Feb 24, 2024
View reviewed changes
src/kernel/src/signal/mod.rs Outdated Show resolved Hide resolved
src/kernel/src/signal/set.rs Outdated Show resolved Hide resolved
@ultimaweapon ultimaweapon merged commit e0ecd19 into obhq:main Feb 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ultimaweapon ultimaweapon ultimaweapon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuchAFuriousDeath @ultimaweapon