Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sys_thr_get_name #674

Closed
wants to merge 1 commit into from
Closed

Conversation

mikusp
Copy link
Contributor

@mikusp mikusp commented Feb 19, 2024

No description provided.

@mikusp mikusp requested a review from a team February 19, 2024 18:40
@SuchAFuriousDeath
Copy link
Contributor

SuchAFuriousDeath commented Feb 19, 2024

I'll check this when I have time.

@ultimaweapon This is unrelated to the PR, but what would you think about doing Vthread::current().unwrap() before a syscall is called and passing it as another argument to all the syscall handlers? I feel like it's kind of redundant to do Vthread::current().unwrap() everywhere when we could do it once and then pass it to the function. Maybe there is an issue with it that I don't see.
By pure coincidence, this is actually kind of similar to the actual FreeBSD syscall handlers.

@ultimaweapon
Copy link
Member

I'll check this when I have time.

@ultimaweapon This is unrelated to the PR, but what would you think about doing Vthread::current().unwrap() before a syscall is called and passing it another argument to all the syscall handlers? I feel like it's kind of redundant to do Vthread::current().unwrap() everywhere when we could do it once and then pass it to the function. Maybe there is an issue with it that I don't see.
By pure coincidence, this is actually kind of similar to the actual FreeBSD syscall handlers.

Good idea.

@SuchAFuriousDeath SuchAFuriousDeath linked an issue Mar 1, 2024 that may be closed by this pull request
Copy link

We are closing this PR due to no any activities in the last 30 days. Feel free to re-open it if you would like to continue working on this.

@github-actions github-actions bot closed this Mar 28, 2024
@VocalFan VocalFan reopened this Apr 18, 2024
Copy link

We are closing this PR due to no any activities in the last 30 days. Feel free to re-open it if you would like to continue working on this.

@github-actions github-actions bot closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Implement sys_thr_get_name
4 participants