Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Actions to automatically add/remove S-ready from PRs #691

Merged
merged 6 commits into from
Feb 25, 2024

Conversation

ultimaweapon
Copy link
Member

No description provided.

@VocalFan
Copy link
Member

I get the last one being Build-out-of-date, but what is this one?

@ultimaweapon
Copy link
Member Author

The previous one has some flaws so we will move to this one instead.

@SuchAFuriousDeath
Copy link
Contributor

I've been preliminarily looking at how IPC sockets work, and it looks like it's a looooot of code.

@SuchAFuriousDeath
Copy link
Contributor

From the looks of it, sys_connect binds IPC sockets to a filesystem path.

@SuchAFuriousDeath
Copy link
Contributor

I think socket protocols and address families could (theoretically) be generalized in a nice way, roughly like this. Hopefully we get to do this one day.
image

@SuchAFuriousDeath
Copy link
Contributor

SuchAFuriousDeath commented Feb 24, 2024

Actually more like this:
image
This isn't fully correct, but I think you get the point.

@ultimaweapon
Copy link
Member Author

It is likely needed to be a trait object so the trait needs to be object safe. BTW better to create a discussion instead of hooking into a random issue/PR so we can easily find it.

@ultimaweapon ultimaweapon marked this pull request as ready for review February 25, 2024 07:05
@ultimaweapon ultimaweapon requested a review from a team February 25, 2024 07:06
@SuchAFuriousDeath SuchAFuriousDeath merged commit 4c98b9e into obhq:main Feb 25, 2024
6 checks passed
@ultimaweapon ultimaweapon deleted the pr-label branch February 25, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants