Apply suggestions from code review

src/lints/declarative_macro_missing.ron

@@ -26,7 +26,6 @@ SemverQuery(
                 item {
                     ... on Macro {
                         visibility_limit @filter(op: "=", value: ["$public"])
-                        public_api_eligible @filter(op: "=", value: ["$true"])
                         name @filter(op: "=", value: ["%name"])
                     }
                 }

test_crates/declarative_macro_missing/new/src/lib.rs

@@ -1,3 +1,15 @@
 macro_rules! will_no_longer_be_exported {
     () => {};
-}
+}
+
+#[doc(hidden)]
+#[macro_export]
+macro_rules! became_doc_hidden {
+    () => {};
+}
+
+#[doc(hidden)]
+#[macro_export]
+macro_rules! always_doc_hidden {
+    () => {};
+}

test_crates/declarative_macro_missing/old/src/lib.rs

@@ -10,4 +10,15 @@ macro_rules! will_no_longer_be_exported {
 
 macro_rules! textual_scope_macro_removed {
     () => {};
-}
+}
+
+#[macro_export]
+macro_rules! became_doc_hidden {
+    () => {};
+}
+
+#[doc(hidden)]
+#[macro_export]
+macro_rules! always_doc_hidden {
+    () => {};
+}

test_outputs/query_execution/declarative_macro_missing.snap

@@ -14,5 +14,10 @@ expression: "&query_execution_results"
       "span_begin_line": Uint64(7),
       "span_filename": String("src/lib.rs"),
     },
+    {
+      "name": String("became_doc_hidden"),
+      "span_begin_line": Uint64(16),
+      "span_filename": String("src/lib.rs"),
+    },
   ],
 }

test_outputs/witnesses/declarative_macro_missing.snap

@@ -12,3 +12,8 @@ hint = 'will_be_removed!(...);'
 filename = 'src/lib.rs'
 begin_line = 7
 hint = 'will_no_longer_be_exported!(...);'
+
+[["./test_crates/declarative_macro_missing/"]]
+filename = 'src/lib.rs'
+begin_line = 16
+hint = 'became_doc_hidden!(...);'