feat: added new lint enum_variant_field_deprecated
#1096
Conversation
There was a problem hiding this comment.
This PR is also broadly in the right direction, though it seems to have some of the same issues as #1095. I didn't point out those duplicate issues since I figured you can probably spot them already, but feel free to ask questions if you aren't sure.
| public_api @filter(op: "=", value: ["$true"]) | ||
| } | ||
| variant { | ||
| ... on StructVariant { |
There was a problem hiding this comment.
Tuple variants can also have deprecated fields:
pub enum Example {
Variant(#[deprecated] i64),
}We'll need to add separate lints for struct and tuple variants, so let's name this lint enum_struct_variant_field_deprecated and the tuple one enum_tuple_variant_field_deprecated.
| ... on StructVariant { | ||
| variant_name: name @output | ||
| field { | ||
| field_name: name @output @tag |
There was a problem hiding this comment.
Both variants and their fields can be #[doc(hidden)], so we'll need public_api_eligible checks in both the variant and the field blocks, in both baseline and current. Test cases for all these situations would be good too.
|
Going to close this for inactivity for now, just to un-claim the issue it's attached to. If you get a chance to come back to it and complete it, feel free to reopen the PR. Hope all is well! |
part of #57