-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send an approved public kudos to the #kudos slack channel. #2776
Merged
mkimberlin
merged 18 commits into
develop
from
feature-2751/post-approved-kudos-to-slack
Jan 7, 2025
Merged
Send an approved public kudos to the #kudos slack channel. #2776
mkimberlin
merged 18 commits into
develop
from
feature-2751/post-approved-kudos-to-slack
Jan 7, 2025
+386
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm looking into adding a test for the SlackPoster... |
mkimberlin
reviewed
Jan 2, 2025
} | ||
|
||
public String findUserId(String userEmail) { | ||
String token = System.getenv(env); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this...fixing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires two environment variables:
https://api.slack.com/apps/A081ESV0D5W/install-on-team
The application has already been installed to the #kudos channel. We just need to deploy this and provide the above environment variables.
This is what the test channel looks like: