Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate files with a copyright notice #535

Closed
1 of 5 tasks
Tracked by #450
deemp opened this issue Nov 15, 2024 · 0 comments · Fixed by #536
Closed
1 of 5 tasks
Tracked by #450

Annotate files with a copyright notice #535

deemp opened this issue Nov 15, 2024 · 0 comments · Fixed by #536

Comments

@deemp
Copy link
Member

deemp commented Nov 15, 2024

Details

The #534 introduced a CI job that checks copyright notices in multiple files.

This job fails if some notices are missing or incorrect.

We need that files that the job checks to be annotated with copyright notices so that the job doesn't fail.

Here's the list of files that currently cause errors.

Subtasks

  • Add copyright notices in the files that cause errors
  • Update this function so that it additionally inserts copyright notices into .phi files after copying the files. It's necessary for these generated files. UPD: we don't need to insert comments into .phi files - see let's add copyrights checker to CI pipeline #450 (comment).
  • Learn which license should files generated by BNFC have.
  • If the license required by BNFC is different from LICENSE.txt, create another step in the copyright job Add copyrights checker #534. This step should check the license required by BNFC specifically in Print.hs and Abs.hs. Don't check these files against LICENSE.txt.
  • Update the script in Setup.hs so that after running BNFC it reads the appropriate license file and inserts the copyright notice in Print.hs and Abs.hs. Ensure the license file is in the eo-phi-normalizer directory and is specified in extra-source-files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant