optimization of the adjustNumber function #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I refactored adjustNumber to enhance readability and simplify the logic, reducing the number of checks and iterations over the array.
|
@maxonfjvipon please, review this one |
|
@Akvadevka what ticket your pull request is connected to? What problem did you try to solve? |
|
@maxonfjvipon no ticket. I wrote my purposes in the description. |
maxonfjvipon
requested changes
Oct 30, 2024
| @@ -24,7 +24,7 @@ const hexToInt = function(bytes) { | |||
| byte = parseInt(hex, 16) | |||
| } else { | |||
| throw new Error( | |||
| `Wrong format of element ${hex} in byte array ${bytes}\nShould be either integer of hexadecimal starting with '0x'` | |||
| `Wrong format of element ${hex} in byte array ${bytes}\nShould be either integer of hexadecimal starting with '0x'` | |||
There was a problem hiding this comment.
@Akvadevka there's something wrong with indentation
| @@ -38,19 +38,16 @@ const hexToInt = function(bytes) { | |||
| * @return {Array.<Number>} - Adjusted byte array | |||
| */ | |||
| const adjustNumber = function(bytes) { | |||
| if (bytes.length === 8) { | |||
| const number = bytesOf( | |||
| if (bytes.length !== 8) return bytes; | |||
There was a problem hiding this comment.
@Akvadevka we're trying to avoid many return statements, here's why
| ).asBytes(); | ||
|
|
||
| return bytes.map((byte, index) => | ||
| Math.abs(byte - number[index]) === 256 ? byte - 256 : byte |
There was a problem hiding this comment.
@Akvadevka I don't see the purpose of the change. Replacing if with ternary operator didn't make the code more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored adjustNumber to enhance readability and simplify the logic, reducing the number of checks and iterations over the array.
PR-Codex overview
This PR focuses on improving the
adjustNumberfunction in theeo2js-runtime/src/runtime/bytes-of.jsfile, specifically simplifying its logic and enhancing readability.Detailed summary
bytes.length === 8and replaced it withbytes.length !== 8for early return.bytesby using a ternary operator instead of an if-else structure.