Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#296): fixing home tag #295

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Jun 6, 2024

Ref: #296

PR-Codex overview

The focus of this PR is to update the mvnw function to accept additional flags based on the provided options, enhancing flexibility and customization.

Detailed summary

  • Added flags function to generate Maven flags based on options
  • Updated mvnw function to include additional flags from options

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@yegor256
Copy link
Member

yegor256 commented Jun 6, 2024

@maxonfjvipon no test to reproduce this bug?

@maxonfjvipon maxonfjvipon changed the title fix(#293): fixing home tag fix(#296): fixing home tag Jun 6, 2024
@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

yegor256 commented Jun 6, 2024

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jun 6, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit eba5e9f into objectionary:master Jun 6, 2024
29 checks passed
@rultor
Copy link
Contributor

rultor commented Jun 6, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 28min)

@maxonfjvipon
Copy link
Member Author

@yegor256 let's make a new release with tag 0.21.1

@yegor256
Copy link
Member

yegor256 commented Jun 6, 2024

@rultor release, tag is 0.21.1

@rultor
Copy link
Contributor

rultor commented Jun 6, 2024

@rultor release, tag is 0.21.1

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Jun 6, 2024

@rultor release, tag is 0.21.1

@yegor256 Done! FYI, the full log is here (took me 29min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants