You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@SenjeyB thanks for your contribution, but it's better to maintain the structure of JS files that already exists in this repo. See, how commands are dispatched from the eoc.js file. Your command should be docs. I should be able to run eoc docs to generate documentation. Maybe you can create the first PR with a blank implementation of the command -- it will not generate any documentation, but will work and tests will pass. Then, you continue in the second PR, and so on.
@SenjeyB many thanks for your contribution! I see the following issues:
keeping CSS inside JS is not a good idea, better keep it outside as a .css file (or even LESS or SASS)
rendering HTML as a text is not a good idea, better use XSLT
making such a big pull request may lead to much longer review cycles. Better send a shorter change, which will be easier to merge. Later, send improvements and refinements. Check this out: https://www.yegor256.com/2010/03/04/pdd.html
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an automatic documantation generator.