Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate.java:41-45: Do we need {@link Duplicate} class?... #277

Closed
0pdd opened this issue May 28, 2024 · 1 comment · Fixed by #386
Closed

Duplicate.java:41-45: Do we need {@link Duplicate} class?... #277

0pdd opened this issue May 28, 2024 · 1 comment · Fixed by #386
Assignees
@volodya-lombrozo
Labels
soon This issue will be solved soon

Comments

@0pdd
Copy link

0pdd commented May 28, 2024

The puzzle 229-7fc7abda from #229 has to be resolved:

opeo-maven-plugin/src/main/java/org/eolang/opeo/ast/Duplicate.java

Lines 41 to 45 in 944c2a6

* @todo #229:90min Do we need {@link Duplicate} class?
* We have three classes with rather similar semantics: {@link Duplicate},
* {@link Reference} and {@link Linked}.
* They have similar methods and fields. We need to investigate if we can
* remove one or two of these classes and use the remaining one instead.

The puzzle was created by rultor on 28-May-24.

Estimate: 90 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue May 28, 2024
@rultor
Merge branch '__rultor'
944c2a6
This was referenced May 28, 2024
Closed
Closed
Closed
@volodya-lombrozo volodya-lombrozo self-assigned this Aug 13, 2024
@volodya-lombrozo volodya-lombrozo added the soon This issue will be solved soon label Aug 13, 2024
volodya-lombrozo added a commit to volodya-lombrozo/opeo-maven-plugin that referenced this issue Aug 13, 2024
@volodya-lombrozo
feat(objectionary#277): remove the puzzle for 277 issue
e41b3b1
volodya-lombrozo added a commit to volodya-lombrozo/opeo-maven-plugin that referenced this issue Aug 13, 2024
@volodya-lombrozo
feat(objectionary#277): add unit test for Duplicate node
48043fa
volodya-lombrozo added a commit to volodya-lombrozo/opeo-maven-plugin that referenced this issue Aug 13, 2024
@volodya-lombrozo
feat(objectionary#277): add line attribute for Duplicate node
83e95b6
volodya-lombrozo added a commit to volodya-lombrozo/opeo-maven-plugin that referenced this issue Aug 13, 2024
@volodya-lombrozo
feat(objectionary#277): attempt to replace Reference with Duplicate
e489d75
@volodya-lombrozo volodya-lombrozo mentioned this issue Aug 13, 2024
Merged
volodya-lombrozo added a commit to volodya-lombrozo/opeo-maven-plugin that referenced this issue Aug 14, 2024
@volodya-lombrozo
feat(objectionary#277): repair most of the unit tests
3ce48bf
volodya-lombrozo added a commit to volodya-lombrozo/opeo-maven-plugin that referenced this issue Aug 14, 2024
@volodya-lombrozo
feat(objectionary#277): repair all the integration tests
6defc36
volodya-lombrozo added a commit to volodya-lombrozo/opeo-maven-plugin that referenced this issue Aug 14, 2024
@volodya-lombrozo
feat(objectionary#277): find logical inconsistence between stack popu…
5c98fc5 
…lation and opcode generation
volodya-lombrozo added a commit to volodya-lombrozo/opeo-maven-plugin that referenced this issue Aug 14, 2024
@volodya-lombrozo
feat(objectionary#277): fix all tests
3e5b822
volodya-lombrozo added a commit to volodya-lombrozo/opeo-maven-plugin that referenced this issue Aug 14, 2024
@volodya-lombrozo
feat(objectionary#277): remove old Reference class
b4d7dab
volodya-lombrozo added a commit to volodya-lombrozo/opeo-maven-plugin that referenced this issue Aug 14, 2024
@volodya-lombrozo
feat(objectionary#277): remove 'Linked' class
64150f5
volodya-lombrozo added a commit to volodya-lombrozo/opeo-maven-plugin that referenced this issue Aug 14, 2024
@volodya-lombrozo
feat(objectionary#277): fix all qulice suggestions
5379e54
volodya-lombrozo added a commit to volodya-lombrozo/opeo-maven-plugin that referenced this issue Aug 14, 2024
@volodya-lombrozo
feat(objectionary#277): fix the problem with lines
a39e591
volodya-lombrozo added a commit to volodya-lombrozo/opeo-maven-plugin that referenced this issue Aug 14, 2024
@volodya-lombrozo
feat(objectionary#277): fix the problem with one puzzle
206aade
This was referenced Aug 14, 2024
Open
Open
@0pdd
Copy link
Author

0pdd commented Aug 14, 2024

@0pdd 2 puzzles #387, #388 are still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volodya-lombrozo volodya-lombrozo

Labels
soon This issue will be solved soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#277): Remove Code Duplication Between References volodya-lombrozo/opeo-maven-plugin
2 participants
@0pdd @volodya-lombrozo