-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#277): Remove Code Duplication Between References #386
Conversation
…lation and opcode generation
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here |
@volodya-lombrozo Done! FYI, the full log is here (took me 7min) |
@volodya-lombrozo Thank you for your contribution! We appreciate your effort, but there are a few areas for improvement. You've earned +5 points: +20 base, -7 for excessive hits-of-code (566 ≥ 200), -15 for missing code review, and -5 for insufficient comments (only 2). We encourage you to focus on quality and ensure proper code review in future submissions. Keep up the good work, and don't hesitate to ask for guidance. Your current balance is +201. |
In this PR I combined
Linked
,Reference
andDuplicate
classes into a single well-tested class.Closes: #277.
PR-Codex overview
The focus of this PR is to refactor code in the
opeo
package.Detailed summary
Linked.java
andReference.java
StoreArray
to handle opcodes differentlyInvocation
to handle argumentsConstructor
to handle different nodesRoot
to return opcodesNewArrayAgent
to handle array constructionArrayConstructor
InvokespecialAgent
to handle different nodesXmirParser
to handle referencesDuplicate
StoreToArrayAgent
to handle array storage