Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#344): Identify Problem With INVOKESPECIAL Instruction #360

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Aug 1, 2024

In this PR I identified problem related to INVOKESPECIAL instruction decompilation.
I added one more integration test to reveal the problem and added one more puzzle to solve the problem in the future.

Related to #344.


PR-Codex overview

This PR adds a new Playground class, tests it, and refactors the InvokespecialHandler class.

Detailed summary

  • Added Playground class with isAvailable method
  • Added test for Playground class in Main.java
  • Refactored InvokespecialHandler class in handlers package

The following files were skipped due to too many changes: src/test/resources/xmir/disassembled/WebProperties$Resources$Chain$Strategy$Content.xmir

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 1, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 8e5f7f7 into objectionary:master Aug 1, 2024
11 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 1, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 8min)

@0crat
Copy link

0crat commented Aug 1, 2024

@volodya-lombrozo Thanks for the contribution! You've earned +5 points for this: +30 as a basis; -7 for too many hits-of-code (251 >= 100); -15 for the lack of code review; -10 for too few (2) comments; +7 to give you at least something. Please, keep them coming. Your running balance is +274.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants