Add prop to Bar to animate only when progress is increasing #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `strokeCap` prop for `Progress.Circle` Changes: Allows for further customization of the `Progress.Circle` by adding a `strokeCap` prop, similar to the `Progress.CircleSnail` component. * Add prop to Arc to allow for custom strokeCap * Update project readme
* Add strokeCap prop to CircleSnail * Update CircleSnail README
…l back if not available. (oblador#70)
…oblador#65) * fix strokeCap prop not being passed to foreground arc from Circle component The default prop was being used, and the circle progress bar was always being rendered with 'butt' type strokeCap * add circlePercent and rotationOffset parameters to Circle.js * Revert "add circlePercent and rotationOffset parameters to Circle.js" This reverts commit b209640.
* Add native driver support and smooth bar animation * update readme * revert changes on circles and only change bar * add animationOptions prop * update readme to include animationOptions * remove whitespace * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to reset the bar progress after it was complete, several times in a row, but the animation made it look very confusing (it was going back and forth).
So I added this simple prop to animate the progress change only if the new value is greater than the previous one.
Not sure about the prop naming, or if it can be useful to others, but anyway, here you go.