Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #2154 [NTR-cxg] cortical region-agnostic L2/3-6 intratelencephalic projecting glutamatergic cortical neuron (by layer) #2181

Merged
4 commits merged into from
Oct 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 12, 2023

Addresses #2154 [NTR] cortical region-agnostic L2/3-6 intratelencephalic projecting glutamatergic cortical neuron (by layer)

#gogoeditdiff

@ghost ghost added the new term request label Oct 12, 2023
@ghost ghost self-assigned this Oct 12, 2023
@ghost ghost added the cellxgene label Oct 12, 2023
@ghost ghost changed the title Addresses #2154 [NTR] cortical region-agnostic L2/3-6 intratelencephalic projecting glutamatergic cortical neuron (by layer) Addresses #2154 [NTR-cxg] cortical region-agnostic L2/3-6 intratelencephalic projecting glutamatergic cortical neuron (by layer) Oct 12, 2023
@ghost ghost added the CL-classhierarchy label Oct 12, 2023
@ghost
Copy link
Author

ghost commented Oct 13, 2023

@anitacaron, any advice on why this is failing QC?

fastobo-validator cl-check.obo
     Parsing `cl-check.obo`
      Failed parsing `cl-check.obo`
             --> cl-check.obo:31176:10
              |
        31176 | xref: An intratelencephalic-projecting glutamatergic neuron with a soma found in cortical layer 5. {xref="PMID:37292694", xref="PMID:37609206"}␊
              |          ^---
              |
              = expected EOL or QuotedString
make: *** [cl.Makefile:190: obocheck] Error 1

@anitacaron
Copy link
Contributor

I checked on Protégé, and you're using database_cross_reference instead of definition annotation 😃
The two new terms with issue are CL:4030064 and CL:4030065.

Screenshot 2023-10-13 at 08 55 20

@ghost
Copy link
Author

ghost commented Oct 13, 2023

I checked on Protégé, and you're using database_cross_reference instead of definition annotation 😃

Thank you for spotting that!

@ghost
Copy link
Author

ghost commented Oct 13, 2023

#gogoeditdiff

@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-10-13/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-10-13/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

CL_4030059 http://purl.obolibrary.org/obo/CL_4030059

Added

CL_4030060 http://purl.obolibrary.org/obo/CL_4030060

Added

CL_4030061 http://purl.obolibrary.org/obo/CL_4030061

Added

CL_4030062 http://purl.obolibrary.org/obo/CL_4030062

Added

CL_4030063 http://purl.obolibrary.org/obo/CL_4030063

Added

CL_4030064 http://purl.obolibrary.org/obo/CL_4030064

Added

CL_4030065 http://purl.obolibrary.org/obo/CL_4030065

Added

L2/3 intratelencephalic projecting glutamatergic neuron of the primary motor cortex http://purl.obolibrary.org/obo/CL_4023047

Removed

Added

L4/5 intratelencephalic projecting glutamatergic neuron of the primary motor cortex http://purl.obolibrary.org/obo/CL_4023048

Removed

Added

L5 intratelencephalic projecting glutamatergic neuron of the primary motor cortex http://purl.obolibrary.org/obo/CL_4023049

Removed

Added

L6 intratelencephalic projecting glutamatergic neuron of the primary motor cortex http://purl.obolibrary.org/obo/CL_4023050

Removed

Added

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

CL_4030059 http://purl.obolibrary.org/obo/CL_4030059

Added

CL_4030060 http://purl.obolibrary.org/obo/CL_4030060

Added

CL_4030061 http://purl.obolibrary.org/obo/CL_4030061

Added

CL_4030062 http://purl.obolibrary.org/obo/CL_4030062

Added

CL_4030063 http://purl.obolibrary.org/obo/CL_4030063

Added

CL_4030064 http://purl.obolibrary.org/obo/CL_4030064

Added

CL_4030065 http://purl.obolibrary.org/obo/CL_4030065

Added

L2/3 intratelencephalic projecting glutamatergic neuron of the primary motor cortex http://purl.obolibrary.org/obo/CL_4023047

Removed

Added

L4/5 intratelencephalic projecting glutamatergic neuron of the primary motor cortex http://purl.obolibrary.org/obo/CL_4023048

Removed

Added

L5 intratelencephalic projecting glutamatergic neuron of the primary motor cortex http://purl.obolibrary.org/obo/CL_4023049

Removed

Added

L6 intratelencephalic projecting glutamatergic neuron of the primary motor cortex http://purl.obolibrary.org/obo/CL_4023050

Removed

Added

@ghost ghost requested review from dosumis and aleixpuigb October 13, 2023 08:23
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No breaking changes noted.

@ghost ghost merged commit 9f6b379 into master Oct 13, 2023
1 check passed
@ghost ghost deleted the 2154-NTR-IT_projecting_glu_neuron branch October 13, 2023 14:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR-cxg] Add region neutral children of L2/3-6 intratelencephalic projecting glutamatergic cortical neuron
2 participants