Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subset tag for CellxGene usage #2252

Closed
dosumis opened this issue Dec 21, 2023 · 4 comments · Fixed by #2267
Closed

Add subset tag for CellxGene usage #2252

dosumis opened this issue Dec 21, 2023 · 4 comments · Fixed by #2267
Assignees

Comments

@dosumis
Copy link
Contributor

dosumis commented Dec 21, 2023

Investigate whether we can mine CxG Census to find all CL terms in use on CxG. If yes, build GA pipeline to mine CxG for a CL term list + ROBOT pipeline to tage CL terms with subset tag: cellxgene_subset. (If not possible - request functionality from CxG Census?)

@anitacaron - this is very similar to what we already do for HRA. Can you point @hkir-dev to existing pipelines?

@anitacaron
Copy link
Contributor

The pipeline for HRA is in the ccf-validation-tools. It might be better to use the subset pipeline from ODK, the same as the other subsets here, e.g. eye, kidney, etc.

@anitacaron
Copy link
Contributor

Or generate a component from the ROBOT template.

@hkir-dev
Copy link
Contributor

I prepared an experimental project https://github.com/hkir-dev/cellxgene-cell-reporter

A nightly build GitHub action is generating

@anitacaron how can we integrate this to CL?

@anitacaron
Copy link
Contributor

The template file should be in src/templates. ODK will generate the owl file in the src/ontology/components, no need to add it.

  • 2. Inside src/ontology, run sh run.sh make update_repo

  • 3. Add the component URL to the catalog: example

    <uri name="http://purl.obolibrary.org/obo/cl/components/kidney_upper_slim.owl" uri="components/kidney_upper_slim.owl"/>

  • 4. Add the component URL as an import in the cl-edit (in alphabetical order): example Import(<http://purl.obolibrary.org/obo/cl/components/kidney_upper_slim.owl>)

  • 5. Add a rule to update the template in cl.Makefile: the example is downloading a component because there isn't a template, but in your case, you should download the template. (In the next ODK version, this step won't be necessary; we'll be able to just pass the link to an external template in the cl-odk.yaml file)

    HRA_SUBSET_URL="https://raw.githubusercontent.com/hubmapconsortium/ccf-validation-tools/master/owl/CL_ASCTB_subset.owl"
    $(TMPDIR)/hra_subset.owl:
    wget $(HRA_SUBSET_URL) -O $@
    $(COMPONENTSDIR)/hra_subset.owl: $(TMPDIR)/hra_subset.owl
    $(ROBOT) merge -i $< annotate --ontology-iri $(ONTBASE)/$@ --output $@

  • 6. Inside src/ontology, run sh run.sh make components/{owl file name} to generate the owl file

Let me know if you need further help.

@anitacaron anitacaron linked a pull request Jan 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants