Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching has_(not)_completed to RO terms #1491

Closed
wants to merge 1 commit into from

Conversation

shawntanzk
Copy link
Contributor

Switch has_completed to output_of
Switch has_not_completed to capable_of
See oborel/obo-relations#574
Related to #1481
tagging @bpeters42
will not merge unless we have approval from @addiehl

Switch has_completed to output_of
Switch has_not_completed to capable_of
See oborel/obo-relations#574
Related to #1481
@shawntanzk shawntanzk requested review from dosumis and addiehl March 9, 2022 11:25
@shawntanzk shawntanzk self-assigned this Mar 9, 2022
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Here's a diff of how these changes impact the classified ontology:

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2022-03-09/cl.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-master.owl/cl.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2022-03-09/cl.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-pr.owl/cl.owl

Ontology imports

Ontology annotations

Bm4 B cell http://purl.obolibrary.org/obo/CL_0000966

Removed

Added

Bm5 B cell http://purl.obolibrary.org/obo/CL_0000967

Removed

Added

CD27-negative gamma-delta T cell http://purl.obolibrary.org/obo/CL_0002125

Removed

Added

CD27-positive gamma-delta T cell http://purl.obolibrary.org/obo/CL_0002124

Removed

Added

CD4-positive helper T cell http://purl.obolibrary.org/obo/CL_0000492

Removed

Added

CD4-positive, alpha-beta cytotoxic T cell http://purl.obolibrary.org/obo/CL_0000934

Removed

Added

CD4-positive, alpha-beta memory T cell http://purl.obolibrary.org/obo/CL_0000897

Removed

Added

CD4-positive, alpha-beta memory T cell, CD45RO-positive http://purl.obolibrary.org/obo/CL_0001204

Removed

Added

CD8-positive, alpha-beta cytokine secreting effector T cell http://purl.obolibrary.org/obo/CL_0000908

Removed

Added

CD8-positive, alpha-beta cytotoxic T cell http://purl.obolibrary.org/obo/CL_0000794

Removed

Added

CD8-positive, alpha-beta memory T cell http://purl.obolibrary.org/obo/CL_0000909

Removed

Added

CD8-positive, alpha-beta memory T cell, CD45RO-positive http://purl.obolibrary.org/obo/CL_0001203

Removed

Added

Fraction C precursor B cell http://purl.obolibrary.org/obo/CL_0002049

Removed

Added

Fraction D precursor B cell http://purl.obolibrary.org/obo/CL_0002052

Removed

Added

Gr1-positive, CD43-positive monocyte http://purl.obolibrary.org/obo/CL_0002398

Added

class switched memory B cell http://purl.obolibrary.org/obo/CL_0000972

Removed

Added

effector T cell http://purl.obolibrary.org/obo/CL_0000911

Removed

Added

effector memory CD4-positive, alpha-beta T cell, terminally differentiated http://purl.obolibrary.org/obo/CL_0001087

Removed

Added

effector memory CD8-positive, alpha-beta T cell, terminally differentiated http://purl.obolibrary.org/obo/CL_0001062

Removed

Added

has_completed http://purl.obolibrary.org/obo/cl#has_completed

Removed

has_not_completed http://purl.obolibrary.org/obo/cl#has_not_completed

Removed

immature B cell http://purl.obolibrary.org/obo/CL_0000816

Removed

Added

immature T cell http://purl.obolibrary.org/obo/CL_0002420

Removed

Added

immature alpha-beta T cell http://purl.obolibrary.org/obo/CL_0000790

Removed

Added

immature gamma-delta T cell http://purl.obolibrary.org/obo/CL_0000799

Removed

Added

intermediate monocyte http://purl.obolibrary.org/obo/CL_0002393

Removed

Added

mature B cell http://purl.obolibrary.org/obo/CL_0000785

Removed

Added

mature NK T cell http://purl.obolibrary.org/obo/CL_0000814

Removed

Added

mature T cell http://purl.obolibrary.org/obo/CL_0002419

Removed

Added

mature alpha-beta T cell http://purl.obolibrary.org/obo/CL_0000791

Removed

Added

mature gamma-delta T cell http://purl.obolibrary.org/obo/CL_0000800

Removed

Added

memory B cell http://purl.obolibrary.org/obo/CL_0000787

Removed

Added

memory T cell http://purl.obolibrary.org/obo/CL_0000813

Removed

Added

memory regulatory T cell http://purl.obolibrary.org/obo/CL_0002678

Removed

Added

mucosal invariant T cell http://purl.obolibrary.org/obo/CL_0000940

Removed

Added

naive B cell http://purl.obolibrary.org/obo/CL_0000788

Removed

Added

naive T cell http://purl.obolibrary.org/obo/CL_0000898

Removed

Added

non-classical monocyte http://purl.obolibrary.org/obo/CL_0000875

Removed

Added

pre-B-II cell http://purl.obolibrary.org/obo/CL_0000955

Removed

Added

preBCR-negative large pre-B-II cell http://purl.obolibrary.org/obo/CL_0000953

Removed

Added

preBCR-positive large pre-B-II cell http://purl.obolibrary.org/obo/CL_0000952

Removed

Added

primary oocyte http://purl.obolibrary.org/obo/CL_0000654

Removed

Added

secondary oocyte http://purl.obolibrary.org/obo/CL_0000655

Removed

Added

thymocyte http://purl.obolibrary.org/obo/CL_0000893

Removed

Added

transitional stage B cell http://purl.obolibrary.org/obo/CL_0000818

Removed

Added

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

Bm4 B cell http://purl.obolibrary.org/obo/CL_0000966

Removed

Added

Bm5 B cell http://purl.obolibrary.org/obo/CL_0000967

Removed

Added

CD27-negative gamma-delta T cell http://purl.obolibrary.org/obo/CL_0002125

Removed

Added

CD27-positive gamma-delta T cell http://purl.obolibrary.org/obo/CL_0002124

Removed

Added

CD4-positive helper T cell http://purl.obolibrary.org/obo/CL_0000492

Removed

Added

CD4-positive, alpha-beta cytotoxic T cell http://purl.obolibrary.org/obo/CL_0000934

Removed

Added

CD4-positive, alpha-beta memory T cell http://purl.obolibrary.org/obo/CL_0000897

Removed

Added

CD4-positive, alpha-beta memory T cell, CD45RO-positive http://purl.obolibrary.org/obo/CL_0001204

Removed

Added

CD8-positive, alpha-beta cytokine secreting effector T cell http://purl.obolibrary.org/obo/CL_0000908

Removed

Added

CD8-positive, alpha-beta cytotoxic T cell http://purl.obolibrary.org/obo/CL_0000794

Removed

Added

CD8-positive, alpha-beta memory T cell http://purl.obolibrary.org/obo/CL_0000909

Removed

Added

CD8-positive, alpha-beta memory T cell, CD45RO-positive http://purl.obolibrary.org/obo/CL_0001203

Removed

Added

Fraction C precursor B cell http://purl.obolibrary.org/obo/CL_0002049

Removed

Added

Fraction D precursor B cell http://purl.obolibrary.org/obo/CL_0002052

Removed

Added

class switched memory B cell http://purl.obolibrary.org/obo/CL_0000972

Removed

Added

effector T cell http://purl.obolibrary.org/obo/CL_0000911

Removed

Added

effector memory CD4-positive, alpha-beta T cell, terminally differentiated http://purl.obolibrary.org/obo/CL_0001087

Removed

Added

effector memory CD8-positive, alpha-beta T cell, terminally differentiated http://purl.obolibrary.org/obo/CL_0001062

Removed

Added

has_completed http://purl.obolibrary.org/obo/cl#has_completed

Removed

has_not_completed http://purl.obolibrary.org/obo/cl#has_not_completed

Removed

immature B cell http://purl.obolibrary.org/obo/CL_0000816

Removed

Added

immature T cell http://purl.obolibrary.org/obo/CL_0002420

Removed

Added

immature alpha-beta T cell http://purl.obolibrary.org/obo/CL_0000790

Removed

Added

immature gamma-delta T cell http://purl.obolibrary.org/obo/CL_0000799

Removed

Added

intermediate monocyte http://purl.obolibrary.org/obo/CL_0002393

Removed

Added

mature B cell http://purl.obolibrary.org/obo/CL_0000785

Removed

Added

mature NK T cell http://purl.obolibrary.org/obo/CL_0000814

Removed

Added

mature T cell http://purl.obolibrary.org/obo/CL_0002419

Removed

Added

mature alpha-beta T cell http://purl.obolibrary.org/obo/CL_0000791

Removed

Added

mature gamma-delta T cell http://purl.obolibrary.org/obo/CL_0000800

Removed

Added

memory B cell http://purl.obolibrary.org/obo/CL_0000787

Removed

Added

memory T cell http://purl.obolibrary.org/obo/CL_0000813

Removed

Added

memory regulatory T cell http://purl.obolibrary.org/obo/CL_0002678

Removed

Added

mucosal invariant T cell http://purl.obolibrary.org/obo/CL_0000940

Removed

Added

naive B cell http://purl.obolibrary.org/obo/CL_0000788

Removed

Added

naive T cell http://purl.obolibrary.org/obo/CL_0000898

Removed

Added

non-classical monocyte http://purl.obolibrary.org/obo/CL_0000875

Removed

Added

pre-B-II cell http://purl.obolibrary.org/obo/CL_0000955

Removed

Added

preBCR-negative large pre-B-II cell http://purl.obolibrary.org/obo/CL_0000953

Removed

Added

preBCR-positive large pre-B-II cell http://purl.obolibrary.org/obo/CL_0000952

Removed

Added

primary oocyte http://purl.obolibrary.org/obo/CL_0000654

Removed

Added

secondary oocyte http://purl.obolibrary.org/obo/CL_0000655

Removed

Added

thymocyte http://purl.obolibrary.org/obo/CL_0000893

Removed

Added

transitional stage B cell http://purl.obolibrary.org/obo/CL_0000818

Removed

Added

@dosumis dosumis marked this pull request as draft March 9, 2022 11:33
@dosumis
Copy link
Contributor

dosumis commented Mar 9, 2022

Very useful to see all changed examples together. Looks like there's plenty to discuss here, so have converted to Draft pending discussion on CL call.

@addiehl
Copy link
Contributor

addiehl commented Mar 10, 2022

Please do not switch has_not_completed to capable_of. They do not mean the same thing. See oborel/obo-relations#574 for my suggestion.

@ghost
Copy link

ghost commented Nov 24, 2022

@shawntanzk, can we update or close this PR? There has been no noted activity for > 6 months.

@shawntanzk
Copy link
Contributor Author

I'm going to close this for now, we need to resolve the discussion in oborel/obo-relations#574 for this to move on

@shawntanzk shawntanzk closed this Nov 24, 2022
@shawntanzk shawntanzk deleted the has_completed-change branch November 24, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants