-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addresses #2150 Standardise annotation property: abbreviation #2159
Conversation
#gogoeditdiff |
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsD1/D2-hybrid medium spiny neuron
|
@anitacaron, can you help troubleshoot this error? Level Rule Name Subject Property Value There appears to be only one definition... |
@bvarner-ebi, where do you see this error? The error failing the QC in this branch is
I'll check why it's not getting the label from the merged_import.owl |
The QC report output mentions: "*** [Makefile:199: reports/cl-edit.owl-obo-report.tsv] Error 1"
Thank you. |
The file The 5 first violations on this report are what you see in the QC log. |
Thanks for the explanation. Should the other report file be deleted or renamed to avoid confusion? |
You can remove them, please. |
This reverts commit 56d9fde.
The issue appeared after this commit 677cd19. This axiom is part of the property in OMO, you can remove it. I'm checking to import this too. |
This reverts commit 677cd19.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems ok, but just to double check, the deletion of the import of http://purl.obolibrary.org/obo/uberon/core#ABBREVIATION
will be addressed in a different ticket as you mentioned in the ticket, right? As it is not used I wasn't sure if it could just be removed.
Thank you for checking. If http://purl.obolibrary.org/obo/uberon/core#ABBREVIATION is not removed after the Uberon updates have been made and refreshed in CL, it can be deleted in CL. |
Addresses #2150: Standardise annotation property: abbreviation