Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #2150 Standardise annotation property: abbreviation #2159

Merged
5 commits merged into from
Sep 26, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 25, 2023

Addresses #2150: Standardise annotation property: abbreviation

@ghost ghost added synonym maintenance Simple fixes identified during maintenance reviews or while working on other issues labels Sep 25, 2023
@ghost ghost self-assigned this Sep 25, 2023
@ghost
Copy link
Author

ghost commented Sep 25, 2023

#gogoeditdiff

@ghost ghost linked an issue Sep 25, 2023 that may be closed by this pull request
@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-09-25/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-09-25/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

D1/D2-hybrid medium spiny neuron http://purl.obolibrary.org/obo/CL_4030050

Removed

Added

Feyrter cell http://purl.obolibrary.org/obo/CL_0002066

Removed

Added

H1 horizontal cell http://purl.obolibrary.org/obo/CL_0004217

Removed

Added

H2 horizontal cell http://purl.obolibrary.org/obo/CL_0004218

Removed

Added

Island of Calleja granule cell http://purl.obolibrary.org/obo/CL_4030053

Removed

Added

L5 extratelencephalic projecting glutamatergic cortical neuron http://purl.obolibrary.org/obo/CL_4023041

Removed

Added

OMO_0003000 http://purl.obolibrary.org/obo/OMO_0003000

Added

ON-blue cone bipolar cell http://purl.obolibrary.org/obo/CL_4033019

Removed

Added

RXFP1-positive interface island D1-medium spiny neuron http://purl.obolibrary.org/obo/CL_4030054

Removed

Added

abbreviation http://purl.obolibrary.org/obo/cl#abbreviation

Removed

alveolar capillary type 1 endothelial cell http://purl.obolibrary.org/obo/CL_4028002

Removed

Added

alveolar capillary type 2 endothelial cell http://purl.obolibrary.org/obo/CL_4028003

Removed

Added

alveolar type 1 fibroblast cell http://purl.obolibrary.org/obo/CL_4028004

Removed

Added

alveolar type 2 fibroblast cell http://purl.obolibrary.org/obo/CL_4028006

Removed

Added

amacrine cell http://purl.obolibrary.org/obo/CL_0000561

Removed

Added

arachnoid barrier cell http://purl.obolibrary.org/obo/CL_4023097

Removed

Added

bone marrow macrophage http://purl.obolibrary.org/obo/CL_0002476

Removed

Added

cardioblast http://purl.obolibrary.org/obo/CL_0002664

Removed

Added

cerebellar granule cell precursor http://purl.obolibrary.org/obo/CL_0002362

Removed

Added

common lymphoid progenitor http://purl.obolibrary.org/obo/CL_0000051

Removed

Added

common myeloid progenitor http://purl.obolibrary.org/obo/CL_0000049

Removed

Added

common myeloid progenitor, CD34-positive http://purl.obolibrary.org/obo/CL_0001059

Removed

Added

dental pulp stem cell http://purl.obolibrary.org/obo/CL_4030035

Removed

Added

differentiation-committed oligodendrocyte precursor http://purl.obolibrary.org/obo/CL_4023059

Removed

Added

diffuse bipolar 1 cell http://purl.obolibrary.org/obo/CL_4033027

Removed

Added

diffuse bipolar 2 cell http://purl.obolibrary.org/obo/CL_4033028

Removed

Added

diffuse bipolar 3a cell http://purl.obolibrary.org/obo/CL_4033029

Removed

Added

diffuse bipolar 3b cell http://purl.obolibrary.org/obo/CL_4033030

Removed

Added

diffuse bipolar 4 cell http://purl.obolibrary.org/obo/CL_4033031

Removed

Added

diffuse bipolar 6 cell http://purl.obolibrary.org/obo/CL_4033032

Removed

Added

direct pathway medium spiny neuron http://purl.obolibrary.org/obo/CL_4023026

Removed

Added

early lymphoid progenitor http://purl.obolibrary.org/obo/CL_0000936

Removed

Added

eccentric medium spiny neuron http://purl.obolibrary.org/obo/CL_4030057

Removed

Added

enucleate erythrocyte http://purl.obolibrary.org/obo/CL_0000595

Removed

Added

eosinophil progenitor cell http://purl.obolibrary.org/obo/CL_0000611

Removed

Added

erythroid progenitor cell http://purl.obolibrary.org/obo/CL_0000038

Removed

Added

erythroid progenitor cell, mammalian http://purl.obolibrary.org/obo/CL_0001066

Removed

Added

flat midget bipolar cell http://purl.obolibrary.org/obo/CL_4033033

Removed

Added

folliculostellate cell http://purl.obolibrary.org/obo/CL_0000642

Removed

Added

gamma-delta T cell http://purl.obolibrary.org/obo/CL_0000798

Removed

Added

giant bipolar cell http://purl.obolibrary.org/obo/CL_4033035

Removed

Added

glial restricted tripotential precursor cell http://purl.obolibrary.org/obo/CL_4040000

Removed

Added

globular bushy cell http://purl.obolibrary.org/obo/CL_4023164

Removed

Added

granulocyte monocyte progenitor cell http://purl.obolibrary.org/obo/CL_0000557

Removed

Added

hematopoietic stem cell http://purl.obolibrary.org/obo/CL_0000037

Removed

Added

hepatic stem cell http://purl.obolibrary.org/obo/CL_0002195

Removed

Added

indirect pathway medium spiny neuron http://purl.obolibrary.org/obo/CL_4023029

Removed

Added

invaginating midget bipolar cell http://purl.obolibrary.org/obo/CL_4033034

Removed

Added

lung interstitial macrophage http://purl.obolibrary.org/obo/CL_4033043

Removed

Added

lung megakaryocyte http://purl.obolibrary.org/obo/CL_4033018

Removed

Added

lung migratory dendritic cell http://purl.obolibrary.org/obo/CL_4033045

Removed

Added

lung neuroendocrine cell http://purl.obolibrary.org/obo/CL_1000223

Removed

Added

lung perichondrial fibroblast http://purl.obolibrary.org/obo/CL_4033026

Removed

Added

lung resident memory CD4-positive, alpha-beta T cell http://purl.obolibrary.org/obo/CL_4033038

Removed

Added

lung resident memory CD8-positive, alpha-beta T cell http://purl.obolibrary.org/obo/CL_4033039

Removed

Added

matrix D1 medium spiny neuron http://purl.obolibrary.org/obo/CL_4030043

Removed

Added

matrix D2 medium spiny neuron http://purl.obolibrary.org/obo/CL_4030047

Removed

Added

mature CD4 single-positive thymocyte http://purl.obolibrary.org/obo/CL_0002436

Removed

Added

medullary reticular cell http://purl.obolibrary.org/obo/CL_0009106

Removed

Added

mesenchymal stem cell http://purl.obolibrary.org/obo/CL_0000134

Removed

Added

monoblast http://purl.obolibrary.org/obo/CL_0000040

Removed

Added

multi-ciliated epithelial cell http://purl.obolibrary.org/obo/CL_0005012

Removed

Added

nucleus accumbens shell and olfactory tubercle D1 medium spiny neuron http://purl.obolibrary.org/obo/CL_4030051

Removed

Added

nucleus accumbens shell and olfactory tubercle D2 medium spiny neuron http://purl.obolibrary.org/obo/CL_4030052

Removed

Added

oligodendrocyte precursor cell http://purl.obolibrary.org/obo/CL_0002453

Removed

Added

oxytocin receptor sst GABAergic cortical interneuron http://purl.obolibrary.org/obo/CL_4023122

Removed

Added

peg cell http://purl.obolibrary.org/obo/CL_4033014

Removed

Added

professional antigen presenting cell http://purl.obolibrary.org/obo/CL_0000145

Removed

Added

retina horizontal cell http://purl.obolibrary.org/obo/CL_0000745

Removed

Added

retinal bipolar neuron http://purl.obolibrary.org/obo/CL_0000748

Removed

Added

retinal ganglion cell http://purl.obolibrary.org/obo/CL_0000740

Removed

Added

secondary crest myofibroblast http://purl.obolibrary.org/obo/CL_4033016

Removed

Added

small bistratified retinal ganglion cell http://purl.obolibrary.org/obo/CL_4033053

Removed

Added

spherical bushy cell http://purl.obolibrary.org/obo/CL_4023163

Removed

Added

striosomal D1 medium spiny neuron http://purl.obolibrary.org/obo/CL_4030048

Removed

Added

striosomal D2 medium spiny neuron http://purl.obolibrary.org/obo/CL_4030049

Removed

Added

valve endothelial cell http://purl.obolibrary.org/obo/CL_4030033

Removed

Added

valve interstitial cell http://purl.obolibrary.org/obo/CL_4030032

Removed

Added

von Economo neuron http://purl.obolibrary.org/obo/CL_4030039

Removed

Added

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

D1/D2-hybrid medium spiny neuron http://purl.obolibrary.org/obo/CL_4030050

Removed

Added

Feyrter cell http://purl.obolibrary.org/obo/CL_0002066

Removed

Added

H1 horizontal cell http://purl.obolibrary.org/obo/CL_0004217

Removed

Added

H2 horizontal cell http://purl.obolibrary.org/obo/CL_0004218

Removed

Added

Island of Calleja granule cell http://purl.obolibrary.org/obo/CL_4030053

Removed

Added

L5 extratelencephalic projecting glutamatergic cortical neuron http://purl.obolibrary.org/obo/CL_4023041

Removed

Added

ON-blue cone bipolar cell http://purl.obolibrary.org/obo/CL_4033019

Removed

Added

RXFP1-positive interface island D1-medium spiny neuron http://purl.obolibrary.org/obo/CL_4030054

Removed

Added

abbreviation http://purl.obolibrary.org/obo/cl#abbreviation

Removed

abbreviation http://purl.obolibrary.org/obo/OMO_0003000

Added

alveolar capillary type 1 endothelial cell http://purl.obolibrary.org/obo/CL_4028002

Removed

Added

alveolar capillary type 2 endothelial cell http://purl.obolibrary.org/obo/CL_4028003

Removed

Added

alveolar type 1 fibroblast cell http://purl.obolibrary.org/obo/CL_4028004

Removed

Added

alveolar type 2 fibroblast cell http://purl.obolibrary.org/obo/CL_4028006

Removed

Added

amacrine cell http://purl.obolibrary.org/obo/CL_0000561

Removed

Added

arachnoid barrier cell http://purl.obolibrary.org/obo/CL_4023097

Removed

Added

bone marrow macrophage http://purl.obolibrary.org/obo/CL_0002476

Removed

Added

cardioblast http://purl.obolibrary.org/obo/CL_0002664

Removed

Added

cerebellar granule cell precursor http://purl.obolibrary.org/obo/CL_0002362

Removed

Added

common lymphoid progenitor http://purl.obolibrary.org/obo/CL_0000051

Removed

Added

common myeloid progenitor http://purl.obolibrary.org/obo/CL_0000049

Removed

Added

common myeloid progenitor, CD34-positive http://purl.obolibrary.org/obo/CL_0001059

Removed

Added

dental pulp stem cell http://purl.obolibrary.org/obo/CL_4030035

Removed

Added

differentiation-committed oligodendrocyte precursor http://purl.obolibrary.org/obo/CL_4023059

Removed

Added

diffuse bipolar 1 cell http://purl.obolibrary.org/obo/CL_4033027

Removed

Added

diffuse bipolar 2 cell http://purl.obolibrary.org/obo/CL_4033028

Removed

Added

diffuse bipolar 3a cell http://purl.obolibrary.org/obo/CL_4033029

Removed

Added

diffuse bipolar 3b cell http://purl.obolibrary.org/obo/CL_4033030

Removed

Added

diffuse bipolar 4 cell http://purl.obolibrary.org/obo/CL_4033031

Removed

Added

diffuse bipolar 6 cell http://purl.obolibrary.org/obo/CL_4033032

Removed

Added

direct pathway medium spiny neuron http://purl.obolibrary.org/obo/CL_4023026

Removed

Added

early lymphoid progenitor http://purl.obolibrary.org/obo/CL_0000936

Removed

Added

eccentric medium spiny neuron http://purl.obolibrary.org/obo/CL_4030057

Removed

Added

enucleate erythrocyte http://purl.obolibrary.org/obo/CL_0000595

Removed

Added

eosinophil progenitor cell http://purl.obolibrary.org/obo/CL_0000611

Removed

Added

erythroid progenitor cell http://purl.obolibrary.org/obo/CL_0000038

Removed

Added

erythroid progenitor cell, mammalian http://purl.obolibrary.org/obo/CL_0001066

Removed

Added

flat midget bipolar cell http://purl.obolibrary.org/obo/CL_4033033

Removed

Added

folliculostellate cell http://purl.obolibrary.org/obo/CL_0000642

Removed

Added

gamma-delta T cell http://purl.obolibrary.org/obo/CL_0000798

Removed

Added

giant bipolar cell http://purl.obolibrary.org/obo/CL_4033035

Removed

Added

glial restricted tripotential precursor cell http://purl.obolibrary.org/obo/CL_4040000

Removed

Added

globular bushy cell http://purl.obolibrary.org/obo/CL_4023164

Removed

Added

granulocyte monocyte progenitor cell http://purl.obolibrary.org/obo/CL_0000557

Removed

Added

hematopoietic stem cell http://purl.obolibrary.org/obo/CL_0000037

Removed

Added

hepatic stem cell http://purl.obolibrary.org/obo/CL_0002195

Removed

Added

indirect pathway medium spiny neuron http://purl.obolibrary.org/obo/CL_4023029

Removed

Added

invaginating midget bipolar cell http://purl.obolibrary.org/obo/CL_4033034

Removed

Added

lung interstitial macrophage http://purl.obolibrary.org/obo/CL_4033043

Removed

Added

lung megakaryocyte http://purl.obolibrary.org/obo/CL_4033018

Removed

Added

lung migratory dendritic cell http://purl.obolibrary.org/obo/CL_4033045

Removed

Added

lung neuroendocrine cell http://purl.obolibrary.org/obo/CL_1000223

Removed

Added

lung perichondrial fibroblast http://purl.obolibrary.org/obo/CL_4033026

Removed

Added

lung resident memory CD4-positive, alpha-beta T cell http://purl.obolibrary.org/obo/CL_4033038

Removed

Added

lung resident memory CD8-positive, alpha-beta T cell http://purl.obolibrary.org/obo/CL_4033039

Removed

Added

matrix D1 medium spiny neuron http://purl.obolibrary.org/obo/CL_4030043

Removed

Added

matrix D2 medium spiny neuron http://purl.obolibrary.org/obo/CL_4030047

Removed

Added

mature CD4 single-positive thymocyte http://purl.obolibrary.org/obo/CL_0002436

Removed

Added

medullary reticular cell http://purl.obolibrary.org/obo/CL_0009106

Removed

Added

mesenchymal stem cell http://purl.obolibrary.org/obo/CL_0000134

Removed

Added

monoblast http://purl.obolibrary.org/obo/CL_0000040

Removed

Added

multi-ciliated epithelial cell http://purl.obolibrary.org/obo/CL_0005012

Removed

Added

nucleus accumbens shell and olfactory tubercle D1 medium spiny neuron http://purl.obolibrary.org/obo/CL_4030051

Removed

Added

nucleus accumbens shell and olfactory tubercle D2 medium spiny neuron http://purl.obolibrary.org/obo/CL_4030052

Removed

Added

oligodendrocyte precursor cell http://purl.obolibrary.org/obo/CL_0002453

Removed

Added

oxytocin receptor sst GABAergic cortical interneuron http://purl.obolibrary.org/obo/CL_4023122

Removed

Added

peg cell http://purl.obolibrary.org/obo/CL_4033014

Removed

Added

professional antigen presenting cell http://purl.obolibrary.org/obo/CL_0000145

Removed

Added

retina horizontal cell http://purl.obolibrary.org/obo/CL_0000745

Removed

Added

retinal bipolar neuron http://purl.obolibrary.org/obo/CL_0000748

Removed

Added

retinal ganglion cell http://purl.obolibrary.org/obo/CL_0000740

Removed

Added

secondary crest myofibroblast http://purl.obolibrary.org/obo/CL_4033016

Removed

Added

small bistratified retinal ganglion cell http://purl.obolibrary.org/obo/CL_4033053

Removed

Added

spherical bushy cell http://purl.obolibrary.org/obo/CL_4023163

Removed

Added

striosomal D1 medium spiny neuron http://purl.obolibrary.org/obo/CL_4030048

Removed

Added

striosomal D2 medium spiny neuron http://purl.obolibrary.org/obo/CL_4030049

Removed

Added

valve endothelial cell http://purl.obolibrary.org/obo/CL_4030033

Removed

Added

valve interstitial cell http://purl.obolibrary.org/obo/CL_4030032

Removed

Added

von Economo neuron http://purl.obolibrary.org/obo/CL_4030039

Removed

Added

@ghost
Copy link
Author

ghost commented Sep 25, 2023

@anitacaron, can you help troubleshoot this error?

Level Rule Name Subject Property Value
ERROR multiple_definitions sncg GABAergic cortical interneuron definition A GABAergic neuron located in the cerebral cortex that expresses Gamma-synuclein
ERROR multiple_definitions sncg GABAergic cortical interneuron definition xref:(ILX:0770150)

There appears to be only one definition...

@anitacaron
Copy link
Contributor

@bvarner-ebi, where do you see this error?

The error failing the QC in this branch is

ERROR	missing_label	OMO:0003000	rdfs:label	

I'll check why it's not getting the label from the merged_import.owl

@ghost
Copy link
Author

ghost commented Sep 25, 2023

@bvarner-ebi, where do you see this error?

The QC report output mentions: "*** [Makefile:199: reports/cl-edit.owl-obo-report.tsv] Error 1"
Looking at that file now, it looks like it is 2 years old, so please disregard.

I'll check why it's not getting the label from the merged_import.owl

Thank you.

@ghost
Copy link
Author

ghost commented Sep 25, 2023

I'll check why it's not getting the label from the merged_import.owl

The label does appear in Protégé. Thank you for investigating why it's not being recognised.

Screenshot 2023-09-25 at 14 20 11

@anitacaron
Copy link
Contributor

The QC report output mentions: "*** [Makefile:199: reports/cl-edit.owl-obo-report.tsv] Error 1"
Looking at that file now, it looks like it is 2 years old, so please disregard.

The file reports/cl-edit.owl-obo-report.tsv is related to src/ontology.

The 5 first violations on this report are what you see in the QC log.

Screenshot 2023-09-25 at 14 26 16

@ghost
Copy link
Author

ghost commented Sep 25, 2023

The QC report output mentions: "*** [Makefile:199: reports/cl-edit.owl-obo-report.tsv] Error 1"
Looking at that file now, it looks like it is 2 years old, so please disregard.

The file reports/cl-edit.owl-obo-report.tsv is related to src/ontology.

The 5 first violations on this report are what you see in the QC log.

Screenshot 2023-09-25 at 14 26 16

Thanks for the explanation. Should the other report file be deleted or renamed to avoid confusion?

@anitacaron
Copy link
Contributor

You can remove them, please.

@ghost ghost mentioned this pull request Sep 25, 2023
@anitacaron
Copy link
Contributor

The issue appeared after this commit 677cd19. This axiom is part of the property in OMO, you can remove it. I'm checking to import this too.

This reverts commit 677cd19.
@ghost ghost requested review from anitacaron and aleixpuigb September 25, 2023 14:43
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems ok, but just to double check, the deletion of the import of http://purl.obolibrary.org/obo/uberon/core#ABBREVIATION will be addressed in a different ticket as you mentioned in the ticket, right? As it is not used I wasn't sure if it could just be removed.

@ghost
Copy link
Author

ghost commented Sep 25, 2023

All seems ok, but just to double check, the deletion of the import of http://purl.obolibrary.org/obo/uberon/core#ABBREVIATION will be addressed in a different ticket as you mentioned in the ticket, right? As it is not used I wasn't sure if it could just be removed.

Thank you for checking.

If http://purl.obolibrary.org/obo/uberon/core#ABBREVIATION is not removed after the Uberon updates have been made and refreshed in CL, it can be deleted in CL.

@ghost ghost merged commit 0734405 into master Sep 26, 2023
1 check passed
@ghost ghost deleted the 2150-replace_abbreviation_syn_type_prop branch September 26, 2023 08:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Simple fixes identified during maintenance reviews or while working on other issues synonym
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardise annotation property: abbreviation
2 participants