Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2166 revision of Hofbauer cell #2170

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Fixes #2166 revision of Hofbauer cell #2170

merged 5 commits into from
Oct 6, 2023

Conversation

aleixpuigb
Copy link
Collaborator

@aleixpuigb aleixpuigb commented Oct 4, 2023 •
edited
Loading

Fixes #2166 revision of Hofbauer cell

@aleixpuigb
Fixes #2166 class hierarchy Hofbauer cell
ddbd028 
Fixes #2166 class hierarchy Hofbauer cell
@aleixpuigb aleixpuigb added CL-classhierarchy HuBMAP Needed/useful for HuBMAP labels Oct 4, 2023
@aleixpuigb aleixpuigb self-assigned this Oct 4, 2023
@aleixpuigb aleixpuigb requested a review from a user October 4, 2023 12:51
ghost
ghost reviewed Oct 4, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments.
Will defer to assignee's judgment on whether to incorporate suggestions.

src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
@aleixpuigb
Copy link
Collaborator Author

Thank you for your comments, @bvarner-ebi.
This cell was automatically generated, so the definition is outdated, the reference is not adequate (the definition is from wikipedia, but it is not referenced) and human specific. It is also missing an abbreviated synonym (HBC). I will go back to the original ticket to propose further edits.

@aleixpuigb aleixpuigb changed the title Fixes #2166 class hierarchy Hofbauer cell Fixes #2166 revision of Hofbauer cell Oct 5, 2023
@aleixpuigb aleixpuigb requested a review from a user October 6, 2023 08:17
ghost
ghost reviewed Oct 6, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defer content review to SME.
Please see inline comments.

@aleixpuigb aleixpuigb merged commit 88b458d into master Oct 6, 2023
1 check passed
@aleixpuigb aleixpuigb deleted the 2166_Hofbauer_cell branch October 6, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@aleixpuigb aleixpuigb

Labels
CL-classhierarchy HuBMAP Needed/useful for HuBMAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Class hierarchy]Hofbauer cell CL:0000235 is a tissue resident macrophage
1 participant
@aleixpuigb