Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ontobot-change-agent to create PRs based on appropriate Issues. #2211

Merged
merged 16 commits into from
Nov 2, 2023

Conversation

hrshdhgd
Copy link
Contributor

@hrshdhgd hrshdhgd commented Oct 31, 2023

This PR adds a workflow ontobot.yml which monitors issues created and on finding issues following a particular pattern (with issue starting with Hey ontobot, apply: followed by KGCL commands as bullets) will trigger the workflow that performs suitable actions on the resource file and create a PR reflecting the changes reflected.

Example:

TODO: Have a GH_TOKEN in the secrets section of this repo for all of this to work.

@cmungall
Copy link
Member

I added GH_TOKEN

@cmungall cmungall marked this pull request as ready for review October 31, 2023 21:44
@cmungall cmungall requested a review from gouttegd October 31, 2023 21:44
echo "branch-name=kgcl_automation_"${{ steps.gh-script-issue.outputs.result }} >> $GITHUB_ENV

- name: Get jar & create alias command.
run: wget https://github.com/gouttegd/kgcl-java/releases/download/kgcl-0.2.0/kgcl-robot-standalone-0.2.0.jar -O kgcl-robot.jar
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is downloading a full-fledged ROBOT archive (nearly ~90 MB). It’s a shame given that the plugin version is only ~2 MB and ROBOT now has support for plugins.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll open a ticket on ontobot-change-agent to discuss how the agent could be updated to use a ROBOT plugin when available.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket is here: INCATools/ontobot-change-agent#67

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime, I have no objection to start using ontobot-change-agent without waiting for that change to be implemented. It can always be updated later.

gouttegd
gouttegd previously approved these changes Nov 1, 2023
Copy link
Collaborator

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed above, I think we should avoid downloading a full version of ROBOT just for the kgcl command, but this is something that can always be improved later.

It looks good to me and I’m eager to see it in action.

@hrshdhgd hrshdhgd requested a review from gouttegd November 2, 2023 17:23
@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Nov 2, 2023

@gouttegd : I have updated the workflow to use kgcl-java as a robot plugin (for robot within ODK) rather than downloading the standalone resource (although that feature is also available) - exactly as you had envisioned.

@hrshdhgd hrshdhgd merged commit 324d6f6 into obophenotype:master Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants