-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ontobot-change-agent
to create PRs based on appropriate Issues.
#2211
Conversation
I added GH_TOKEN |
.github/workflows/ontobot.yml
Outdated
echo "branch-name=kgcl_automation_"${{ steps.gh-script-issue.outputs.result }} >> $GITHUB_ENV | ||
|
||
- name: Get jar & create alias command. | ||
run: wget https://github.com/gouttegd/kgcl-java/releases/download/kgcl-0.2.0/kgcl-robot-standalone-0.2.0.jar -O kgcl-robot.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is downloading a full-fledged ROBOT archive (nearly ~90 MB). It’s a shame given that the plugin version is only ~2 MB and ROBOT now has support for plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll open a ticket on ontobot-change-agent to discuss how the agent could be updated to use a ROBOT plugin when available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ticket is here: INCATools/ontobot-change-agent#67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime, I have no objection to start using ontobot-change-agent without waiting for that change to be implemented. It can always be updated later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed above, I think we should avoid downloading a full version of ROBOT just for the kgcl
command, but this is something that can always be improved later.
It looks good to me and I’m eager to see it in action.
@gouttegd : I have updated the workflow to use |
This PR adds a workflow
ontobot.yml
which monitors issues created and on finding issues following a particular pattern (with issue starting withHey ontobot, apply:
followed by KGCL commands as bullets) will trigger the workflow that performs suitable actions on the resource file and create a PR reflecting the changes reflected.Example:
TODO: Have a
GH_TOKEN
in the secrets section of this repo for all of this to work.