Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1889 neuroendocrine cell #2235

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

aleixpuigb
Copy link
Collaborator

Fixes #1889 neuroendocrine cell

@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

Copy link

github-actions bot commented Nov 24, 2023

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-09-19/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-09-19/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

adrenal cortex chromaffin cell http://purl.obolibrary.org/obo/CL_1000427

Removed

adrenal medulla chromaffin cell http://purl.obolibrary.org/obo/CL_0000336

Added

chromaffin cell http://purl.obolibrary.org/obo/CL_0000166

Removed

Added

chromaffin cell of adrenal gland http://purl.obolibrary.org/obo/CL_1000426

Removed

chromaffin cell of ovary http://purl.obolibrary.org/obo/CL_1000465

Removed

chromophil cell of anterior pituitary gland http://purl.obolibrary.org/obo/CL_0000637

Added

lung neuroendocrine cell http://purl.obolibrary.org/obo/CL_1000223

Removed

Added

neuroendocrine cell http://purl.obolibrary.org/obo/CL_0000165

Removed

  • neuroendocrine cell definition "A neuron that is capable of some hormone secretion in response to neuronal signals."

  • neuroendocrine cell comment "The neurosecretory cell is neither an ordinary neuron nor an endocrine cell, but a combination of both. Its neuronal features resemble those of ordinary neurons concerning both structure and function. The production of a visible secretory material marks the neurosecretory neuron as a gland cell, and the fact that extractable cellular products act in the manner of hormones places it in the realm of endocrine elements.

The modern definition of neurosecretion has evolved to include the release of any neuronal secretory product from a neuron."

Added

neuroendocrine cell of epithelium of lobar bronchus http://purl.obolibrary.org/obo/CL_4033010

Removed

parvocellular neurosecretory cell http://purl.obolibrary.org/obo/CL_1001505

Removed

Added

pinealocyte http://purl.obolibrary.org/obo/CL_0000652

Removed

Added

type EC enteroendocrine cell http://purl.obolibrary.org/obo/CL_0000577

Added

Copy link

github-actions bot commented Nov 24, 2023

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

chromaffin cell of adrenal gland http://purl.obolibrary.org/obo/CL_1000426

Removed

lung neuroendocrine cell http://purl.obolibrary.org/obo/CL_1000223

Added

neuroendocrine cell http://purl.obolibrary.org/obo/CL_0000165

Removed

  • neuroendocrine cell definition "A neuron that is capable of some hormone secretion in response to neuronal signals."

  • neuroendocrine cell comment "The neurosecretory cell is neither an ordinary neuron nor an endocrine cell, but a combination of both. Its neuronal features resemble those of ordinary neurons concerning both structure and function. The production of a visible secretory material marks the neurosecretory neuron as a gland cell, and the fact that extractable cellular products act in the manner of hormones places it in the realm of endocrine elements.

The modern definition of neurosecretion has evolved to include the release of any neuronal secretory product from a neuron."

Added

src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

@aleixpuigb aleixpuigb requested a review from dosumis November 30, 2023 15:28
Copy link

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so.

@aleixpuigb
Copy link
Collaborator Author

Hi @dosumis, I think all discussed edits have been implemented. Cheers!

Copy link

github-actions bot commented Feb 4, 2024

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so.

@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

Copy link

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so.

@gouttegd
Copy link
Collaborator

@dosumis: Given that it has been a long time since the last discussion on #1889, is the fix proposed here (which is basically to define neuroendocrine cell as 'endocrine cell that is part_of some 'neuroendocrine system', as suggested in this comment) still your preferred approach? Or should we rethink about the entire issue?

@dosumis
Copy link
Contributor

dosumis commented Sep 19, 2024

#gogoeditdiff

Note - we will ask for feedback on this issue from the Gut Cell Atlas team - who will be reviewing EC cells, a number of which are sometimes classified as neuro-endocrine.

@scheuerm
Copy link
Collaborator

This is also a cell type defined in the lung atlas and so we should make sure that the definition is consistent with this location as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

neuroendocrine cell
4 participants