Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Term Request TAC3-Positive interneurons #2303

Merged
merged 11 commits into from
Mar 25, 2024
Merged

New Term Request TAC3-Positive interneurons #2303

merged 11 commits into from
Mar 25, 2024

Conversation

AvolaAmg
Copy link
Collaborator

@AvolaAmg AvolaAmg commented Mar 4, 2024

Fixes #2300

New Term Request TAC3-Positive interneurons
@AvolaAmg AvolaAmg self-assigned this Mar 4, 2024
@AvolaAmg AvolaAmg requested a review from dosumis March 4, 2024 12:34
@anitacaron
Copy link
Contributor

@AvolaAmg, could you please exchange the title and the description?

@AvolaAmg AvolaAmg changed the title Fixes #2300 New Term Request TAC3-Positive interneurons Mar 4, 2024
@dosumis
Copy link
Contributor

dosumis commented Mar 4, 2024

#gogoeditdiff

Copy link

github-actions bot commented Mar 4, 2024

Your branch is 2 commit/s behind, please update your branch.

@dosumis
Copy link
Contributor

dosumis commented Mar 4, 2024

Your branch is 2 commit/s behind, please update your branch.

I have updated.

@dosumis
Copy link
Contributor

dosumis commented Mar 4, 2024

#gogoeditdiff

(trying to get diff reports to trigger)

Copy link

github-actions bot commented Mar 4, 2024

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-03-07/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-03-07/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

CL_4042001 http://purl.obolibrary.org/obo/CL_4042001

Added

Copy link

github-actions bot commented Mar 4, 2024

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

CL_4042001 http://purl.obolibrary.org/obo/CL_4042001

Added

@dosumis
Copy link
Contributor

dosumis commented Mar 5, 2024

The name sounds super-general (like it applies to any interneuron expressing Tac3) but the axioms are quite specific. Do we really know that all Tac3 expressing interneurons have a soma in the striatum. Isn't it possible that someone will find a Tac3 expressing interneuron elsewhere in the brain?

@AvolaAmg
Copy link
Collaborator Author

AvolaAmg commented Mar 5, 2024

@dosumis Thanks for your comment. You are right I did not consider that possibility, I considered the informations in the literature where these cells are described and I used the name that they used in this paper PMID:34727523.
I could either modify the cell label and be more specific about their location, and/or I could do a more in depth literature search to see whether other TAC3 positive interneurons are found elsewhere. Let me know what you think.

@scheuerm
Copy link
Collaborator

scheuerm commented Mar 5, 2024

In the Bakken et al paper (PMID: 34616062), there is a cell type labelled "Inc L3-5 VIP TAC3", which was incorporated into PCL. However, TAC3 is not a very good marker for this cell type and was not selected by NS-Forest (the markers for this cell type were TSHZ2 (Hsap), COL19A1 (Hsap), SOX2-OT (Hsap)). TAC3 was selected as an NS-Forest marker for a number of other interneuron types (see OLS screenshot attached). But I'm not sure if this a logical grouping or not.
Screenshot 2024-03-05 at 4 19 55 PM

@AvolaAmg
Copy link
Collaborator Author

AvolaAmg commented Mar 7, 2024

#gogoeditdiff

Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, see inline comments

src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks ok!

@aleixpuigb aleixpuigb merged commit 43dfb7d into master Mar 25, 2024
1 check passed
@aleixpuigb aleixpuigb deleted the Fixes-#2300 branch March 25, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] TAC3-positive interneuron
5 participants