Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTR dermal chromatophore #2308

Merged
merged 2 commits into from
Mar 19, 2024
Merged

NTR dermal chromatophore #2308

merged 2 commits into from
Mar 19, 2024

Conversation

paulacalipho
Copy link
Collaborator

fixes #2307

@paulacalipho paulacalipho requested a review from aleixpuigb March 7, 2024 09:44
@paulacalipho paulacalipho self-assigned this Mar 7, 2024
aleixpuigb
aleixpuigb requested changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the PR.
Please, consider the suggested changes.

src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
@paulacalipho
Copy link
Collaborator Author

@aleixpuigb @dosumis Thank you for reviewing. I get this warning, and I do not understand what it means and what I should do
image

@paulacalipho paulacalipho requested a review from aleixpuigb March 19, 2024 06:23
@anitacaron
Copy link
Contributor

@paulacalipho, no worries. It's just a difference between Operational Systems and how they interpret the line ending in the file.

@paulacalipho
Copy link
Collaborator Author

@aleixpuigb I understood I did not need to do the logical definition, right? Is there anything else to improve?

aleixpuigb
aleixpuigb approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleixpuigb I understood I did not need to do the logical definition, right? Is there anything else to improve?

That's correct, the logical definition is not needed. Everything looks good, thank you!

@paulacalipho
Copy link
Collaborator Author

@aleixpuigb thanks, It is indicated merging is blocked. Could you do it for me?

@aleixpuigb aleixpuigb merged commit d4ce4fa into master Mar 19, 2024
1 check passed
@aleixpuigb aleixpuigb deleted the #2307-NTR-dermal-chromatophore branch March 19, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosumis dosumis dosumis left review comments

@aleixpuigb aleixpuigb aleixpuigb approved these changes

Assignees

@paulacalipho paulacalipho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NTR] dermal chromatophore
4 participants
@paulacalipho @anitacaron @dosumis @aleixpuigb