Use a dedicated token for the Ontobot workflow. #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the ontobot workflow to make it use a dedicated token (`ONTOBOT_TOKEN`), rather than the default `GITHUB_TOKEN`. This should ensures that PRs created by the bot can trigger other workflows, notably the CI workflow.
hrshdhgd
reviewed
Mar 25, 2024
| @@ -50,7 +50,7 @@ jobs: | |||
| id: gh-script-issue | |||
| uses: actions/github-script@v6 | |||
| with: | |||
| # github-token: ${{ secrets.GH_TOKEN }} | |||
| github-token: ${{ secrets.ONTOBOT_TOKEN }} | |||
There was a problem hiding this comment.
This one may not be needed.
hrshdhgd
reviewed
Mar 25, 2024
| @@ -60,7 +60,7 @@ jobs: | |||
| id: gh-script-repo | |||
| uses: actions/github-script@v6 | |||
| with: | |||
| # github-token: ${{ secrets.GH_TOKEN }} | |||
| github-token: ${{ secrets.ONTOBOT_TOKEN }} | |||
There was a problem hiding this comment.
This one may not be needed.
hrshdhgd
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
The 2 extra places where the secret is passed made no difference to the workflow (when I first tested it). I kept it there at the time just in case. Looking at what the steps are doing, we may not need them at all but it doesn't really impact anything. So I leave it upto you to decide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the ontobot workflow to make it use a dedicated token (
ONTOBOT_TOKEN), rather than the defaultGITHUB_TOKEN.This should ensures that PRs created by the bot can trigger other workflows, notably the CI workflow.
(This is merely the same thing as what was already done on Uberon, for the same reasons.)